Skip to content

Commit 1e547eb

Browse files
committed
address comments
Signed-off-by: huabing zhao <[email protected]>
1 parent d7beeee commit 1e547eb

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

apis/v1alpha2/policy_types.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ type PolicyTargetReference struct {
4646
// Policy resource, refer to the policy attachment documentation for Gateway API.
4747
//
4848
// Note: This should be used for direct policy attachment only.
49-
// <gateway:experimental>
5049
type DirectPolicyTargetReference struct {
5150
PolicyTargetReference `json:",inline"`
5251

geps/gep-713.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1316,8 +1316,8 @@ spec:
13161316
sectionName: bar
13171317
```
13181318

1319-
This would require adding a `Name` field to those sub-resources that currently lack a name. For example,
1320-
a `Name` field could be added to the `RouteRule` object:
1319+
This would require adding a `name` field to those sub-resources that currently lack a name. For example,
1320+
a `name` field could be added to the `RouteRule` object:
13211321
```go
13221322
type RouteRule struct {
13231323
// Name is the name of the Route rule. If more than one Route Rule is
@@ -1337,8 +1337,8 @@ type RouteRule struct {
13371337
If a `sectionName` is specified, but does not exist on the targeted object, the Policy must fail to attach,
13381338
and the policy implementation should record a `resolvedRefs` or similar Condition in the Policy's status.
13391339

1340-
When multiple Policies of the same type target the same object, one with a `SectionName` specified, and one without,
1341-
the one with a `SectionName` is more specific, and so will have all its settings apply. The less-specific Policy will
1340+
When multiple Policies of the same type target the same object, one with a `sectionName` specified, and one without,
1341+
the one with a `sectionName` is more specific, and so will have all its settings apply. The less-specific Policy will
13421342
not attach to the target.
13431343

13441344
Note that the `sectionName` is currently intended to be used only for Direct Policy Attachment. Inherited Policies

0 commit comments

Comments
 (0)