attempt to fix test

Author: LiorLieberman

apis/v1alpha2/validation/httproute_test.go

@@ -29,7 +29,6 @@ import (
 
 func TestValidateHTTPRoute(t *testing.T) {
 	testService := gatewayv1a2.ObjectName("test-service")
-	specialService := gatewayv1a2.ObjectName("special-service")
 	pathPrefixMatchType := gatewayv1b1.PathMatchPathPrefix
 
 	tests := []struct {
@@ -173,7 +172,7 @@ func TestValidateHTTPRoute(t *testing.T) {
 		},
 	}, {
 		name:     "invalid httpRoute with multiple duplicate filters",
-		errCount: 1,
+		errCount: 2,
 		rules: []gatewayv1a2.HTTPRouteRule{
 			{
 				Matches: []gatewayv1a2.HTTPRouteMatch{
@@ -229,15 +228,6 @@ func TestValidateHTTPRoute(t *testing.T) {
 							},
 						},
 					},
-					{
-						Type: gatewayv1b1.HTTPRouteFilterRequestMirror,
-						RequestMirror: &gatewayv1a2.HTTPRequestMirrorFilter{
-							BackendRef: gatewayv1a2.BackendObjectReference{
-								Name: specialService,
-								Port: ptrTo(gatewayv1b1.PortNumber(8080)),
-							},
-						},
-					},
 				},
 			},
 		},

apis/v1beta1/validation/httproute_test.go

@@ -28,7 +28,6 @@ import (
 
 func TestValidateHTTPRoute(t *testing.T) {
 	testService := gatewayv1b1.ObjectName("test-service")
-	specialService := gatewayv1b1.ObjectName("special-service")
 	pathPrefixMatchType := gatewayv1b1.PathMatchPathPrefix
 
 	tests := []struct {
@@ -612,7 +611,7 @@ func TestValidateHTTPBackendUniqueFilters(t *testing.T) {
 		}},
 	}, {
 		name:     "valid httpRoute Rules duplicate mirror filter",
-		errCount: 2,
+		errCount: 0,
 		rules: []gatewayv1b1.HTTPRouteRule{{
 			BackendRefs: []gatewayv1b1.HTTPBackendRef{
 				{

pkg/admission/server_test.go

@@ -235,7 +235,7 @@ func TestServeHTTPSubmissions(t *testing.T) {
 				},
 			},
 			{
-				name: "invalid v1alpha2 HTTPRoute resource with two request mirror filters",
+				name: "valid v1alpha2 HTTPRoute resource with two request mirror filters",
 				reqBody: dedent.Dedent(`{
 						"kind": "AdmissionReview",
 						"apiVersion": "` + apiVersion + `",
@@ -301,11 +301,8 @@ func TestServeHTTPSubmissions(t *testing.T) {
 				wantRespCode: http.StatusOK,
 				wantSuccessResponse: admission.AdmissionResponse{
 					UID:     "7313cd05-eddc-4150-b88c-971a0d53b2ab",
-					Allowed: false,
-					Result: &metav1.Status{
-						Code:    400,
-						Message: "spec.rules[0].filters: Invalid value: \"RequestMirror\": cannot be used multiple times in the same rule",
-					},
+					Allowed: true,
+					Result:  &metav1.Status{},
 				},
 			},
 			{