Skip to content

Conversation

@shmuelk
Copy link
Contributor

@shmuelk shmuelk commented Nov 12, 2025

What type of PR is this?
/kind test

What this PR does / why we need it:
This PR enables the passing of a Kubernetes context into the End to End test utilities.

The llm-d-inference-scheduler will use to enable running End to end tests on pre-existing clusters. There are requests for this capability downstream from the llm-d-inference-scheduler.

In addition a minor change was made to return the kind and name of created objects. This is needed in the llm-d-inference-scheduler to enable it to cleanup after End to end tests run on pre-existing clusters.

Does this PR introduce a user-facing change?:
NONE

@k8s-ci-robot
Copy link
Contributor

@shmuelk: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind test

What this PR does / why we need it:
This PR enables the passing of a Kubernetes context into the End to End test utilities.

The llm-d-inference-scheduler will use to enable running End to end tests on pre-existing clusters. There are requests for this capability downstream from the llm-d-inference-scheduler.

In addition a minor change was made to return the kind and name of created objects. This is needed in the llm-d-inference-scheduler to enable it to cleanup after End to end tests run on pre-existing clusters.

Does this PR introduce a user-facing change?:
NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify
Copy link

netlify bot commented Nov 12, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit e667548
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6914b0089c5f480008d53489
😎 Deploy Preview https://deploy-preview-1853--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 12, 2025
@nirrozenbaum
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum, shmuelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 26384f9 into kubernetes-sigs:main Nov 12, 2025
11 checks passed
@shmuelk shmuelk deleted the e2e-context branch November 16, 2025 14:18
rlakhtakia pushed a commit to rlakhtakia/gateway-api-inference-extension that referenced this pull request Nov 17, 2025
* Enable specifying a K8S context for the E2E tests

Signed-off-by: Shmuel Kallner <[email protected]>

* Return kind/name for created objects

Signed-off-by: Shmuel Kallner <[email protected]>

---------

Signed-off-by: Shmuel Kallner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants