Skip to content

Conversation

@nirrozenbaum
Copy link
Contributor

@nirrozenbaum nirrozenbaum commented Jul 30, 2025

This PR continue the cleanup of legacy code.

  • cleanup of scheduling config package. this was a global variable with env vars for scheduling, this should be removed.
  • moved common/config/.. package to config/.... nothing is this package is common or should be common. it's the dedicated package for the config api (loading config from file/text).
  • updated tests accordingly.

fix #1229

@netlify
Copy link

netlify bot commented Jul 30, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 5f14e71
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/6889cfb6db0b0200084f1f0f
😎 Deploy Preview https://deploy-preview-1263--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirrozenbaum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and danehans July 30, 2025 07:54
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jul 30, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2025
@k8s-ci-robot k8s-ci-robot merged commit a3d98f2 into kubernetes-sigs:main Jul 30, 2025
9 checks passed
@nirrozenbaum nirrozenbaum deleted the scheduler-cfg-cleanup branch July 31, 2025 12:56
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove scheduling/config directory

3 participants