Skip to content

Commit ef498b9

Browse files
committed
addressed code review comments
Signed-off-by: Nir Rozenbaum <[email protected]>
1 parent 662f341 commit ef498b9

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

pkg/epp/scheduling/framework/plugins.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,14 @@ const (
3333
)
3434

3535
// ProfileHandler defines the extension points for handling multi SchedulerProfile instances.
36-
// More specifically, this interface defines the 'PickProfiles' and 'ProcessProfilesResults'
37-
// extension points.
38-
39-
// ProfileHandler
36+
// More specifically, this interface defines the 'Pick' and 'ProcessResults' extension points.
4037
type ProfileHandler interface {
4138
plugins.Plugin
4239
// Pick selects the SchedulingProfiles to run from a list of candidate profiles, while taking into consideration the request properties
4340
// and the previously executed SchedluderProfile cycles along with their results.
4441
Pick(ctx context.Context, request *types.LLMRequest, profiles map[string]*SchedulerProfile, profileResults map[string]*types.ProfileRunResult) map[string]*SchedulerProfile
4542

46-
// ProcessResults handles the outcome of each profile run.
43+
// ProcessResults handles the outcome of the profile runs after all profiles ran succuessfully.
4744
// It may aggregate results, log test profile outputs, or apply custom logic. It specifies in the SchedulingResult the
4845
// key of the primary profile that should be used to get the request selected destination.
4946
ProcessResults(ctx context.Context, request *types.LLMRequest, profileResults map[string]*types.ProfileRunResult) *types.SchedulingResult

pkg/epp/scheduling/scheduler_config.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ package scheduling
1919
import "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/framework"
2020

2121
// NewSchedulerConfig creates a new SchedulerConfig object and returns its pointer.
22-
func NewSchedulerConfig(profilePicker framework.ProfileHandler, profiles map[string]*framework.SchedulerProfile) *SchedulerConfig {
22+
func NewSchedulerConfig(profileHandler framework.ProfileHandler, profiles map[string]*framework.SchedulerProfile) *SchedulerConfig {
2323
return &SchedulerConfig{
24-
profileHandler: profilePicker,
24+
profileHandler: profileHandler,
2525
profiles: profiles,
2626
}
2727
}

0 commit comments

Comments
 (0)