Add unit tests for request body

Author: rlakhtakia

pkg/epp/handlers/request_test.go

@@ -49,15 +49,15 @@ func TestHandleRequestBody(t *testing.T) {
 	// Setup datastore
 	tsModel := "food-review"
 	modelWithTarget := "food-review-0"
-	model1ts := testutil.MakeInferenceModel("model1").
+	model1 := testutil.MakeInferenceModel("model1").
 		CreationTimestamp(metav1.Unix(1000, 0)).
 		ModelName(tsModel).ObjRef()
 	model2 := testutil.MakeInferenceModel("model2").
 		CreationTimestamp(metav1.Unix(1000, 0)).
 		ModelName(modelWithTarget).ObjRef()
 	pmf := backendmetrics.NewPodMetricsFactory(&backendmetrics.FakePodMetricsClient{}, time.Second)
 	ds := datastore.NewDatastore(t.Context(), pmf)
-	ds.ModelSetIfOlder(model1ts)
+	ds.ModelSetIfOlder(model1)
 	ds.ModelSetIfOlder(model2)
 
 	pool := &v1alpha2.InferencePool{
@@ -82,9 +82,7 @@ func TestHandleRequestBody(t *testing.T) {
 	tests := []struct {
 		name         string
 		reqBodyMap   map[string]interface{}
-		reqCtx       *RequestContext
 		wantErrCode  string
-		wantErr      bool
 		wantReqCtx   *RequestContext
 		wantRespBody map[string]interface{}
 	}{
@@ -124,7 +122,6 @@ func TestHandleRequestBody(t *testing.T) {
 		},
 		{
 			name:        "no model defined, expect err",
-			wantErr:     true,
 			wantErrCode: errutil.BadRequest,
 		},
 		{
@@ -133,7 +130,6 @@ func TestHandleRequestBody(t *testing.T) {
 				"model":  "non-existent-model",
 				"prompt": "test prompt",
 			},
-			wantErr:     true,
 			wantErrCode: errutil.BadConfiguration,
 		},
 		{
@@ -142,22 +138,18 @@ func TestHandleRequestBody(t *testing.T) {
 				"model":  "food-review-1",
 				"prompt": "test prompt",
 			},
-			wantErr:     true,
 			wantErrCode: errutil.BadConfiguration,
 		},
 	}
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
 			server := NewStreamingServer(scheduling.NewScheduler(ds), DefaultDestinationEndpointHintMetadataNamespace, DefaultDestinationEndpointHintKey, ds)
-			reqCtx := test.reqCtx
-			if reqCtx == nil {
-				reqCtx = &RequestContext{}
-			}
+			reqCtx := &RequestContext{}
 			req := &extProcPb.ProcessingRequest{}
-			gotReqCtx, err := server.HandleRequestBody(ctx, reqCtx, req, test.reqBodyMap)
+			reqCtx, err := server.HandleRequestBody(ctx, reqCtx, req, test.reqBodyMap)
 
-			if test.wantErr {
+			if test.wantErrCode != "" {
 				if err == nil {
 					t.Fatalf("HandleRequestBody should have returned an error containing '%s', but got nil", test.wantErrCode)
 				}
@@ -172,16 +164,16 @@ func TestHandleRequestBody(t *testing.T) {
 			}
 
 			if test.wantReqCtx != nil {
-				if diff := cmp.Diff(test.wantReqCtx.Model, gotReqCtx.Model); diff != "" {
+				if diff := cmp.Diff(test.wantReqCtx.Model, reqCtx.Model); diff != "" {
 					t.Errorf("HandleRequestBody returned unexpected reqCtx.Model, diff(-want, +got): %v", diff)
 				}
-				if diff := cmp.Diff(test.wantReqCtx.ResolvedTargetModel, gotReqCtx.ResolvedTargetModel); diff != "" {
+				if diff := cmp.Diff(test.wantReqCtx.ResolvedTargetModel, reqCtx.ResolvedTargetModel); diff != "" {
 					t.Errorf("HandleRequestBody returned unexpected reqCtx.ResolvedTargetModel, diff(-want, +got): %v", diff)
 				}
-				if diff := cmp.Diff(test.wantReqCtx.TargetPod, gotReqCtx.TargetPod); diff != "" {
+				if diff := cmp.Diff(test.wantReqCtx.TargetPod, reqCtx.TargetPod); diff != "" {
 					t.Errorf("HandleRequestBody returned unexpected reqCtx.TargetPod, diff(-want, +got): %v", diff)
 				}
-				if diff := cmp.Diff(test.wantReqCtx.TargetEndpoint, gotReqCtx.TargetEndpoint); diff != "" {
+				if diff := cmp.Diff(test.wantReqCtx.TargetEndpoint, reqCtx.TargetEndpoint); diff != "" {
 					t.Errorf("HandleRequestBody returned unexpected reqCtx.TargetEndpoint, diff(-want, +got): %v", diff)
 				}
 			}