diff --git a/.golangci.yml b/.golangci.yml index fdf9f7a93d6a..d36de6d69989 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -271,6 +271,8 @@ linters: - linters: - staticcheck text: 'SA1019: .*(res|result|i|j)\.Requeue is deprecated: Use `RequeueAfter` instead' + # TODO: Remove Requeue step by step + path: internal/controllers/(extensionconfig|machinepool)|util/util.go # TODO: var-naming: avoid meaningless package names by revive # * test/infrastructure/docker/internal/docker/types/ # * bootstrap/kubeadm/types/ diff --git a/bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller_reconciler_test.go b/bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller_reconciler_test.go index 8a39706461e8..d95517ab0260 100644 --- a/bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller_reconciler_test.go +++ b/bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller_reconciler_test.go @@ -18,6 +18,7 @@ package controllers import ( "testing" + "time" . "github.com/onsi/gomega" ctrl "sigs.k8s.io/controller-runtime" @@ -61,7 +62,7 @@ func TestKubeadmConfigReconciler(t *testing.T) { }, }) g.Expect(err).To(Succeed()) - g.Expect(result.Requeue).To(BeFalse()) + g.Expect(result.RequeueAfter).To(Equal(time.Duration(0))) }) }) } diff --git a/bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller_test.go b/bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller_test.go index 449c6fee2288..ca514f47cea6 100644 --- a/bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller_test.go +++ b/bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller_test.go @@ -124,7 +124,6 @@ func TestKubeadmConfigReconciler_Reconcile_ReturnEarlyIfKubeadmConfigIsReady(t * } result, err := k.Reconcile(ctx, request) g.Expect(err).ToNot(HaveOccurred()) - g.Expect(result.Requeue).To(BeFalse()) g.Expect(result.RequeueAfter).To(Equal(time.Duration(0))) } @@ -297,7 +296,6 @@ func TestKubeadmConfigReconciler_Reconcile_ReturnEarlyIfMachineHasDataSecretName actual := &bootstrapv1.KubeadmConfig{} g.Expect(myclient.Get(ctx, client.ObjectKey{Namespace: config.Namespace, Name: config.Name}, actual)).To(Succeed()) g.Expect(err).ToNot(HaveOccurred()) - g.Expect(result.Requeue).To(BeFalse()) g.Expect(result.RequeueAfter).To(Equal(time.Duration(0))) assertHasTrueCondition(g, myclient, request, bootstrapv1.KubeadmConfigDataSecretAvailableCondition) } @@ -476,7 +474,6 @@ func TestKubeadmConfigReconciler_Reconcile_RequeueJoiningNodesIfControlPlaneNotI result, err := k.Reconcile(ctx, tc.request) g.Expect(err).ToNot(HaveOccurred()) - g.Expect(result.Requeue).To(BeFalse()) g.Expect(result.RequeueAfter).To(Equal(30 * time.Second)) assertHasFalseCondition(g, myclient, tc.request, bootstrapv1.KubeadmConfigDataSecretAvailableCondition, bootstrapv1.KubeadmConfigDataSecretNotAvailableReason) }) @@ -528,7 +525,6 @@ func TestKubeadmConfigReconciler_Reconcile_GenerateCloudConfigData(t *testing.T) result, err := k.Reconcile(ctx, request) g.Expect(err).ToNot(HaveOccurred()) - g.Expect(result.Requeue).To(BeFalse()) g.Expect(result.RequeueAfter).To(Equal(time.Duration(0))) cfg, err := getKubeadmConfig(myclient, "control-plane-init-cfg", metav1.NamespaceDefault) @@ -631,7 +627,6 @@ func TestKubeadmConfigReconciler_Reconcile_RequeueIfControlPlaneIsMissingAPIEndp } result, err := k.Reconcile(ctx, request) g.Expect(err).ToNot(HaveOccurred()) - g.Expect(result.Requeue).To(BeFalse()) g.Expect(result.RequeueAfter).To(Equal(10 * time.Second)) actualConfig := &bootstrapv1.KubeadmConfig{} @@ -709,7 +704,6 @@ func TestReconcileIfJoinCertificatesAvailableConditioninNodesAndControlPlaneIsRe } result, err := k.Reconcile(ctx, request) g.Expect(err).ToNot(HaveOccurred()) - g.Expect(result.Requeue).To(BeFalse()) g.Expect(result.RequeueAfter).To(Equal(time.Duration(0))) cfg, err := getKubeadmConfig(myclient, rt.configName, metav1.NamespaceDefault) @@ -786,7 +780,6 @@ func TestReconcileIfJoinNodePoolsAndControlPlaneIsReady(t *testing.T) { } result, err := k.Reconcile(ctx, request) g.Expect(err).ToNot(HaveOccurred()) - g.Expect(result.Requeue).To(BeFalse()) g.Expect(result.RequeueAfter).To(Equal(time.Duration(0))) cfg, err := getKubeadmConfig(myclient, rt.configName, metav1.NamespaceDefault) @@ -993,7 +986,6 @@ func TestKubeadmConfigSecretCreatedStatusNotPatched(t *testing.T) { g.Expect(err).ToNot(HaveOccurred()) result, err := k.Reconcile(ctx, request) g.Expect(err).ToNot(HaveOccurred()) - g.Expect(result.Requeue).To(BeFalse()) g.Expect(result.RequeueAfter).To(Equal(time.Duration(0))) cfg, err := getKubeadmConfig(myclient, "worker-join-cfg", metav1.NamespaceDefault) @@ -1236,7 +1228,6 @@ func TestBootstrapTokenTTLExtension(t *testing.T) { } { result, err := k.Reconcile(ctx, req) g.Expect(err).ToNot(HaveOccurred()) - g.Expect(result.Requeue).To(BeFalse()) g.Expect(result.RequeueAfter).To(Equal(time.Duration(0))) } @@ -2085,7 +2076,6 @@ func TestKubeadmConfigReconciler_Reconcile_ExactlyOneControlPlaneMachineInitiali } result, err := k.Reconcile(ctx, request) g.Expect(err).ToNot(HaveOccurred()) - g.Expect(result.Requeue).To(BeFalse()) g.Expect(result.RequeueAfter).To(Equal(time.Duration(0))) request = ctrl.Request{ @@ -2096,7 +2086,6 @@ func TestKubeadmConfigReconciler_Reconcile_ExactlyOneControlPlaneMachineInitiali } result, err = k.Reconcile(ctx, request) g.Expect(err).ToNot(HaveOccurred()) - g.Expect(result.Requeue).To(BeFalse()) g.Expect(result.RequeueAfter).To(Equal(30 * time.Second)) confList := &bootstrapv1.KubeadmConfigList{} g.Expect(myclient.List(ctx, confList)).To(Succeed()) @@ -2151,7 +2140,6 @@ func TestKubeadmConfigReconciler_Reconcile_PatchWhenErrorOccurred(t *testing.T) result, err := k.Reconcile(ctx, request) g.Expect(err).To(HaveOccurred()) - g.Expect(result.Requeue).To(BeFalse()) g.Expect(result.RequeueAfter).To(Equal(time.Duration(0))) cfg, err := getKubeadmConfig(myclient, "control-plane-init-cfg", metav1.NamespaceDefault)