feat: support setting loggingService and monitoringService

[darkweaver87]

What type of PR is this?
/kind feature

What this PR does / why we need it:

On GKE, loggingService and monitoringService are enabled by default. Some people might don't need it as they have their own observability stack. Moreover, the installed services are not working on ARM architectures.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
I'm not sure if I should add unit tests and where ? gcpmanagedcontrolplane_webhook don't have tests, should I create it ?

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

feat: support setting loggingService and monitoringService

[k8s-ci-robot]

Welcome @darkweaver87!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-gcp 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-gcp has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @darkweaver87. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name	Link
🔨 Latest commit	3e1996f
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/66a78b0e94a9be0008618645
😎 Deploy Preview	https://deploy-preview-1292--kubernetes-sigs-cluster-api-gcp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[salasberryfin]

/ok-to-test

[salasberryfin]

Thanks for the PR @darkweaver87. Looks like you need to fix some linting issues and run make generate.

[darkweaver87]

@salasberryfin thank you for guiding me on this and sorry :-)
It should be better now :-)

[richardcase]

@darkweaver87 - thanks for this change. Would you be able to change the commit messages so they don't include the @

[richardcase]

Should we have some validation for this? Or shall we assume it's a cluster greater than 1.14 and so the only values allowed would be:

• none
• logging.googleapis.com/kubernetes

[darkweaver87]

IIUC the google documentation we can't use logging.googleapis.com for GKE > 1.14 so yes it makes sense. I'll update the PR.
Thanks.

[richardcase]

Thaks @darkweaver87, this looks good to me. Before we merge would you be able to squash your commits?

[darkweaver87]

@richardcase , yes surely. Thanks :-)

[mloiseleur]

/lgtm

[mloiseleur]

@richardcase You said it looked good to you. Would you please do the final approve on this one ?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[darkweaver87]

/remove-lifecycle stale

[mloiseleur]

@richardcase @cpanato Friendly reminder for those who can approve. This PR is quite straightforward.

[cpanato]

seems good

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, darkweaver87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment