Skip to content

Commit deced01

Browse files
authored
Merge pull request #639 from anothertobi/liveness
feat: use new restricted liveness probe endpoint
2 parents 0a235fb + 0920a99 commit deced01

File tree

5 files changed

+11
-12
lines changed

5 files changed

+11
-12
lines changed

charts/README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,8 @@ The following table lists the configurable parameters of the latest NFS CSI Driv
6969
| `controller.runOnControlPlane` | run controller on control plane node |`false` |
7070
| `controller.dnsPolicy` | dnsPolicy of controller driver, available values: `Default`, `ClusterFirstWithHostNet`, `ClusterFirst` | `ClusterFirstWithHostNet` |
7171
| `controller.defaultOnDeletePolicy` | default policy for deleting subdirectory when deleting a volume, available values: `delete`, `retain`, `archive` | `delete` |
72+
| `controller.livenessProbe.host ` | the health check host for the liveness probe | `localhost` |
73+
| `controller.livenessProbe.healthPort ` | the health check port for liveness probe | `29652` |
7274
| `controller.logLevel` | controller driver log level |`5` |
7375
| `controller.workingMountDir` | working directory for provisioner to mount nfs shares temporarily | `/tmp` |
7476
| `controller.affinity` | controller pod affinity | `{}` |
@@ -88,6 +90,7 @@ The following table lists the configurable parameters of the latest NFS CSI Driv
8890
| `node.dnsPolicy` | dnsPolicy of driver node daemonset, available values: `Default`, `ClusterFirstWithHostNet`, `ClusterFirst` |`ClusterFirstWithHostNet`
8991
| `node.maxUnavailable` | `maxUnavailable` value of driver node daemonset | `1`
9092
| `node.logLevel` | node driver log level |`5` |
93+
| `node.livenessProbe.host ` | the health check host for the liveness probe | `localhost` |
9194
| `node.livenessProbe.healthPort ` | the health check port for liveness probe |`29653` |
9295
| `node.affinity` | node pod affinity | {} |
9396
| `node.nodeSelector` | node pod node selector | `{}` |
4 Bytes
Binary file not shown.

charts/latest/csi-driver-nfs/templates/csi-nfs-controller.yaml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ spec:
100100
args:
101101
- --csi-address=/csi/csi.sock
102102
- --probe-timeout=3s
103-
- --health-port={{ .Values.controller.livenessProbe.healthPort }}
103+
- --http-endpoint={{ .Values.controller.livenessProbe.host }}:{{ .Values.controller.livenessProbe.healthPort }}
104104
- --v=2
105105
imagePullPolicy: {{ .Values.image.livenessProbe.pullPolicy }}
106106
volumeMounts:
@@ -137,15 +137,12 @@ spec:
137137
fieldPath: spec.nodeName
138138
- name: CSI_ENDPOINT
139139
value: unix:///csi/csi.sock
140-
ports:
141-
- containerPort: {{ .Values.controller.livenessProbe.healthPort }}
142-
name: healthz
143-
protocol: TCP
144140
livenessProbe:
145141
failureThreshold: 5
146142
httpGet:
143+
host: {{ .Values.controller.livenessProbe.host }}
147144
path: /healthz
148-
port: healthz
145+
port: {{ .Values.controller.livenessProbe.healthPort }}
149146
initialDelaySeconds: 30
150147
timeoutSeconds: 10
151148
periodSeconds: 30

charts/latest/csi-driver-nfs/templates/csi-nfs-node.yaml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ spec:
5252
args:
5353
- --csi-address=/csi/csi.sock
5454
- --probe-timeout=3s
55-
- --health-port={{ .Values.node.livenessProbe.healthPort }}
55+
- --http-endpoint={{ .Values.node.livenessProbe.host }}:{{ .Values.node.livenessProbe.healthPort }}
5656
- --v=2
5757
imagePullPolicy: {{ .Values.image.livenessProbe.pullPolicy }}
5858
volumeMounts:
@@ -118,15 +118,12 @@ spec:
118118
fieldPath: spec.nodeName
119119
- name: CSI_ENDPOINT
120120
value: unix:///csi/csi.sock
121-
ports:
122-
- containerPort: {{ .Values.node.livenessProbe.healthPort }}
123-
name: healthz
124-
protocol: TCP
125121
livenessProbe:
126122
failureThreshold: 5
127123
httpGet:
124+
host: {{ .Values.node.livenessProbe.host }}
128125
path: /healthz
129-
port: healthz
126+
port: {{ .Values.node.livenessProbe.healthPort }}
130127
initialDelaySeconds: 30
131128
timeoutSeconds: 10
132129
periodSeconds: 30

charts/latest/csi-driver-nfs/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ controller:
5353
runOnMaster: false
5454
runOnControlPlane: false
5555
livenessProbe:
56+
host: localhost
5657
healthPort: 29652
5758
logLevel: 5
5859
workingMountDir: /tmp
@@ -103,6 +104,7 @@ node:
103104
maxUnavailable: 1
104105
logLevel: 5
105106
livenessProbe:
107+
host: localhost
106108
healthPort: 29653
107109
affinity: {}
108110
nodeSelector: {}

0 commit comments

Comments
 (0)