chore: upgrade golint version

Author: ScottZhuMS

pkg/nfs/nfs_test.go

@@ -54,7 +54,7 @@ func NewEmptyDriver(emptyField string) *Driver {
 		}
 	}
 	d.volumeLocks = NewVolumeLocks()
-	getter := func(key string) (interface{}, error) { return nil, nil }
+	getter := func(_ string) (interface{}, error) { return nil, nil }
 	d.volStatsCache, _ = azcache.NewTimedCache(time.Minute, getter, false)
 	return d
 }

pkg/nfs/nodeserver.go

@@ -92,7 +92,7 @@ func (ns *NodeServer) NodePublishVolume(_ context.Context, req *csi.NodePublishV
 			if v != "" {
 				var err error
 				if mountPermissions, err = strconv.ParseUint(v, 8, 32); err != nil {
-					return nil, status.Errorf(codes.InvalidArgument, fmt.Sprintf("invalid mountPermissions %s", v))
+					return nil, status.Errorf(codes.InvalidArgument, "invalid mountPermissions %s", v)
 				}
 			}
 		}
@@ -213,7 +213,7 @@ func (ns *NodeServer) NodeGetVolumeStats(_ context.Context, req *csi.NodeGetVolu
 	// check if the volume stats is cached
 	cache, err := ns.Driver.volStatsCache.Get(req.VolumeId, azcache.CacheReadTypeDefault)
 	if err != nil {
-		return nil, status.Errorf(codes.Internal, err.Error())
+		return nil, status.Errorf(codes.Internal, "%v", err)
 	}
 	if cache != nil {
 		resp := cache.(csi.NodeGetVolumeStatsResponse)

pkg/nfs/nodeserver_test.go

@@ -39,7 +39,7 @@ const (
 func TestNodePublishVolume(t *testing.T) {
 	ns, err := getTestNodeServer()
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatalf("%v", err.Error())
 	}
 
 	params := map[string]string{
@@ -208,7 +208,7 @@ func TestNodePublishVolume(t *testing.T) {
 func TestNodeUnpublishVolume(t *testing.T) {
 	ns, err := getTestNodeServer()
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatalf("%v", err.Error())
 	}
 
 	errorTarget := testutil.GetWorkDirPath("error_is_likely_target", t)
@@ -276,7 +276,7 @@ func TestNodeUnpublishVolume(t *testing.T) {
 func TestNodeGetInfo(t *testing.T) {
 	ns, err := getTestNodeServer()
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatalf("%v", err.Error())
 	}
 
 	// Test valid request
@@ -289,7 +289,7 @@ func TestNodeGetInfo(t *testing.T) {
 func TestNodeGetCapabilities(t *testing.T) {
 	ns, err := getTestNodeServer()
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatalf("%v", err.Error())
 	}
 
 	capType := &csi.NodeServiceCapability_Rpc{
@@ -358,7 +358,7 @@ func TestNodeGetVolumeStats(t *testing.T) {
 	_ = makeDir(fakePath)
 	ns, err := getTestNodeServer()
 	if err != nil {
-		t.Fatalf(err.Error())
+		t.Fatalf("%v", err.Error())
 	}
 
 	for _, test := range tests {

pkg/nfs/server.go

@@ -78,7 +78,7 @@ func (s *nonBlockingGRPCServer) serve(endpoint string, ids csi.IdentityServer, c
 	if proto == "unix" {
 		addr = "/" + addr
 		if err := os.Remove(addr); err != nil && !os.IsNotExist(err) {
-			klog.Fatalf("Failed to remove %s, error: %s", addr, err.Error())
+			klog.Fatalf("Failed to remove %s, error: %v", addr, err)
 		}
 	}
 

test/utils/testutil/testutil.go

@@ -26,7 +26,7 @@ import (
 func GetWorkDirPath(dir string, t *testing.T) string {
 	path, err := os.Getwd()
 	if err != nil {
-		t.Fatalf("failed to get working directory: %s", err)
+		t.Fatalf("failed to get working directory: %v", err)
 	}
 	return fmt.Sprintf("%s%c%s", path, os.PathSeparator, dir)
 }