Dedicated yaml tab for Trials (#2034)

* frontend: Create a yaml tab for Trials (#2011)

* Create a dedicated yaml tab for Trials.

Signed-off-by: Elena Zioga <[email protected]>

* frontend: Rename components

* Rename trial-modal component to trial-details.
* Rename trial-modal-overview component to trial-overview.

Signed-off-by: Elena Zioga <[email protected]>

Signed-off-by: Elena Zioga <[email protected]>

Author: elenzio9

pkg/new-ui/v1beta1/frontend/src/app/app-routing.module.ts

@@ -3,7 +3,7 @@ import { Routes, RouterModule } from '@angular/router';
 import { ExperimentsComponent } from './pages/experiments/experiments.component';
 import { ExperimentDetailsComponent } from './pages/experiment-details/experiment-details.component';
 import { ExperimentCreationComponent } from './pages/experiment-creation/experiment-creation.component';
-import { TrialModalComponent } from './pages/experiment-details/trials-table/trial-modal/trial-modal.component';
+import { TrialDetailsComponent } from './pages/experiment-details/trials-table/trial-details/trial-details.component';
 
 const routes: Routes = [
   { path: '', component: ExperimentsComponent },
@@ -14,7 +14,7 @@ const routes: Routes = [
   { path: 'new', component: ExperimentCreationComponent },
   {
     path: 'experiment/:experimentName/trial/:trialName',
-    component: TrialModalComponent,
+    component: TrialDetailsComponent,
   },
 ];
 

pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/trials-table/trial-modal/trial-modal.component.html renamed to pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/trials-table/trial-details/trial-details.component.html

@@ -35,11 +35,19 @@
       <div class="tab-height-fix">
         <mat-tab-group dynamicHeight animationDuration="0ms">
           <mat-tab label="OVERVIEW">
-            <app-trial-modal-overview
-              [trialName]="trialName"
-              [experimentName]="experimentName"
-              [trial]="trialDetails"
-            ></app-trial-modal-overview>
+            <ng-template matTabContent>
+              <app-trial-overview
+                [trialName]="trialName"
+                [experimentName]="experimentName"
+                [trial]="trialDetails"
+              ></app-trial-overview>
+            </ng-template>
+          </mat-tab>
+
+          <mat-tab label="YAML">
+            <ng-template matTabContent>
+              <app-trial-yaml [trialJson]="trialDetails"></app-trial-yaml>
+            </ng-template>
           </mat-tab>
         </mat-tab-group>
       </div>

pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/trials-table/trial-modal/trial-modal.component.scss renamed to pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/trials-table/trial-details/trial-details.component.scss

@@ -4,7 +4,7 @@ import { ReactiveFormsModule } from '@angular/forms';
 import { MatSnackBarModule } from '@angular/material/snack-bar';
 import { MatProgressSpinnerModule } from '@angular/material/progress-spinner';
 
-import { TrialModalComponent } from './trial-modal.component';
+import { TrialDetailsComponent } from './trial-details.component';
 import { BrowserAnimationsModule } from '@angular/platform-browser/animations';
 import { KWABackendService } from 'src/app/services/backend.service';
 import { of } from 'rxjs';
@@ -23,9 +23,9 @@ NamespaceServiceStub = {
   getSelectedNamespace: () => of(),
 };
 
-describe('TrialModalComponent', () => {
-  let component: TrialModalComponent;
-  let fixture: ComponentFixture<TrialModalComponent>;
+describe('TrialDetailsComponent', () => {
+  let component: TrialDetailsComponent;
+  let fixture: ComponentFixture<TrialDetailsComponent>;
   let activatedRouteSpy;
 
   beforeEach(
@@ -47,7 +47,7 @@ describe('TrialModalComponent', () => {
           BrowserAnimationsModule,
           TitleActionsToolbarModule,
         ],
-        declarations: [TrialModalComponent],
+        declarations: [TrialDetailsComponent],
         providers: [
           { provide: ActivatedRoute, useValue: activatedRouteSpy },
           { provide: Router, useValue: {} },
@@ -59,7 +59,7 @@ describe('TrialModalComponent', () => {
   );
 
   beforeEach(() => {
-    fixture = TestBed.createComponent(TrialModalComponent);
+    fixture = TestBed.createComponent(TrialDetailsComponent);
     component = fixture.componentInstance;
     fixture.detectChanges();
   });

pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/trials-table/trial-modal/trial-modal.component.spec.ts renamed to pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/trials-table/trial-details/trial-details.component.spec.ts

@@ -17,11 +17,11 @@ interface ChartPoint {
 }
 
 @Component({
-  selector: 'app-trial-modal',
-  templateUrl: './trial-modal.component.html',
-  styleUrls: ['./trial-modal.component.scss'],
+  selector: 'app-trial-details',
+  templateUrl: './trial-details.component.html',
+  styleUrls: ['./trial-details.component.scss'],
 })
-export class TrialModalComponent implements OnInit {
+export class TrialDetailsComponent implements OnInit {
   trialName: string;
   namespace: string;
   dataLoaded: boolean;

pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/trials-table/trial-modal/trial-modal.component.ts renamed to pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/trials-table/trial-details/trial-details.component.ts

@@ -7,8 +7,9 @@ import { NgxChartsModule } from '@swimlane/ngx-charts';
 import { MatProgressSpinnerModule } from '@angular/material/progress-spinner';
 import { MatTooltipModule } from '@angular/material/tooltip';
 import { MatTabsModule } from '@angular/material/tabs';
-import { TrialModalOverviewModule } from './overview/trial-modal-overview.module';
-import { TrialModalComponent } from './trial-modal.component';
+import { TrialOverviewModule } from './trial-overview/trial-overview.module';
+import { TrialDetailsComponent } from './trial-details.component';
+import { TrialYamlModule } from './trial-yaml/trial-yaml.module';
 
 import {
   TitleActionsToolbarModule,
@@ -17,9 +18,9 @@ import {
 } from 'kubeflow';
 
 @NgModule({
-  declarations: [TrialModalComponent],
+  declarations: [TrialDetailsComponent],
   imports: [
-    TrialModalOverviewModule,
+    TrialOverviewModule,
     CommonModule,
     MatTableModule,
     MatProgressSpinnerModule,
@@ -32,7 +33,8 @@ import {
     LoadingSpinnerModule,
     PanelModule,
     TitleActionsToolbarModule,
+    TrialYamlModule,
   ],
-  exports: [TrialModalComponent],
+  exports: [TrialDetailsComponent],
 })
-export class TrialModalModule {}
+export class TrialDetailsModule {}

pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/trials-table/trial-modal/trial-modal.module.ts renamed to pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/trials-table/trial-details/trial-details.module.ts

@@ -0,0 +1,10 @@
+import { NgModule } from '@angular/core';
+import { ConditionsTableModule, DetailsListModule } from 'kubeflow';
+import { TrialMetricsComponent } from './metrics.component';
+
+@NgModule({
+  declarations: [TrialMetricsComponent],
+  imports: [ConditionsTableModule, DetailsListModule],
+  exports: [TrialMetricsComponent],
+})
+export class TrialMetricsModule {}

pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/trials-table/trial-modal/overview/metrics/metrics.component.html renamed to pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/trials-table/trial-details/trial-overview/metrics/metrics.component.html

@@ -2,21 +2,21 @@ import { async, ComponentFixture, TestBed } from '@angular/core/testing';
 import { MatSnackBarModule } from '@angular/material/snack-bar';
 import { ConditionsTableModule, DetailsListModule } from 'kubeflow';
 
-import { TrialModalMetricsComponent } from './metrics.component';
+import { TrialMetricsComponent } from './metrics.component';
 
-describe('TrialModalMetricsComponent', () => {
-  let component: TrialModalMetricsComponent;
-  let fixture: ComponentFixture<TrialModalMetricsComponent>;
+describe('TrialMetricsComponent', () => {
+  let component: TrialMetricsComponent;
+  let fixture: ComponentFixture<TrialMetricsComponent>;
 
   beforeEach(async(() => {
     TestBed.configureTestingModule({
-      declarations: [TrialModalMetricsComponent],
+      declarations: [TrialMetricsComponent],
       imports: [ConditionsTableModule, DetailsListModule, MatSnackBarModule],
     }).compileComponents();
   }));
 
   beforeEach(() => {
-    fixture = TestBed.createComponent(TrialModalMetricsComponent);
+    fixture = TestBed.createComponent(TrialMetricsComponent);
     component = fixture.componentInstance;
     fixture.detectChanges();
   });

pkg/new-ui/v1beta1/frontend/src/app/pages/experiment-details/trials-table/trial-details/trial-overview/metrics/metrics.component.module.ts

@@ -4,7 +4,7 @@ import { Component, Input } from '@angular/core';
   selector: 'app-metrics-overview',
   templateUrl: './metrics.component.html',
 })
-export class TrialModalMetricsComponent {
+export class TrialMetricsComponent {
   @Input() name: string;
   @Input() latest: string;
   @Input() max: string;