Skip to content

Commit 171be75

Browse files
committed
Few changes
1 parent 6f1fb67 commit 171be75

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ endif
8181
# Update all Katib images.
8282
update-images:
8383
ifeq ($(and $(OLD_PREFIX),$(NEW_PREFIX),$(TAG)),)
84-
$(error echo "OLD_PREFIX, NEW_PREFIX, and TAG must be set." \
84+
$(error OLD_PREFIX, NEW_PREFIX, and TAG must be set. \
8585
Usage: make update-images OLD_PREFIX=<old-prefix> NEW_PREFIX=<new-prefix> TAG=<tag> \
8686
For more information, check this file: scripts/v1beta1/update-images.sh)
8787
endif

scripts/v1beta1/update-images.sh

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,16 @@ echo "Image new prefix: ${NEW_PREFIX}"
6262
echo -e "Image tag: ${TAG}\n"
6363

6464
# Katib Core images.
65+
INSTALLS_PATH="manifests/v1beta1/installs/"
66+
6567
echo -e "Updating Katib Core images\n"
66-
update_yaml_files "manifests/v1beta1/installs/" "newName: ${OLD_PREFIX}" "newName: ${NEW_PREFIX}"
67-
update_yaml_files "manifests/v1beta1/installs/" "newTag: .*" "newTag: ${TAG}"
68+
update_yaml_files "${INSTALLS_PATH}" "newName: ${OLD_PREFIX}" "newName: ${NEW_PREFIX}"
69+
update_yaml_files "${INSTALLS_PATH}" "newTag: .*" "newTag: ${TAG}"
6870

6971
# Katib Config images.
7072
CONFIG_PATH="manifests/v1beta1/components/controller/katib-config.yaml"
7173

72-
echo -e "Update Katib Metrics Collectors, Suggestion and EarlyStopping images\n"
74+
echo -e "Update Katib Metrics Collectors, Suggestions and EarlyStopping images\n"
7375
update_yaml_files "${CONFIG_PATH}" "${OLD_PREFIX}" "${NEW_PREFIX}"
7476
update_yaml_files "${CONFIG_PATH}" ":[^[:space:]].*\"" ":${TAG}\""
7577

test/e2e/v1beta1/scripts/setup-katib.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ kubectl cluster-info
3434
# Update Katib images with the current PULL SHA.
3535
make update-images OLD_PREFIX="docker.io/kubeflowkatib/" NEW_PREFIX="${ECR_REGISTRY}/${REPO_NAME}/v1beta1/" TAG="${PULL_PULL_SHA}"
3636

37-
echo -e "\n The Katib will be deployed with the following images"
37+
echo -e "\n The Katib will be deployed with the following configs"
3838
cat "manifests/v1beta1/installs/katib-standalone/kustomization.yaml"
3939
cat "manifests/v1beta1/components/controller/katib-config.yaml"
4040

0 commit comments

Comments
 (0)