Skip to content

Notification channel#69

Closed
dododedodonl wants to merge 10 commits into
beste:mainfrom
dododedodonl:notification-channel
Closed

Notification channel#69
dododedodonl wants to merge 10 commits into
beste:mainfrom
dododedodonl:notification-channel

Conversation

@dododedodonl
Copy link
Copy Markdown
Contributor

Adds a notification channel that supports Tokens, Topics and Conditions.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 1, 2020

Codecov Report

Merging #69 (82ec2e1) into main (68e5def) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##                main       #69   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        46        65   +19     
===========================================
  Files              3         5    +2     
  Lines            127       169   +42     
===========================================
+ Hits             127       169   +42     
Impacted Files Coverage Δ Complexity Δ
src/Exception/MessagingChannelException.php 100.00% <100.00%> (ø) 1.00 <1.00> (?)
src/Notifications/FirebaseMessagingChannel.php 100.00% <100.00%> (ø) 18.00 <18.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e5def...687fd15. Read the comment docs.

@ankurk91
Copy link
Copy Markdown
Contributor

@jeromegamez

Any plans to merge this PR?

@dododedodonl
Copy link
Copy Markdown
Contributor Author

Features provided by this PR are now also available in https://github.com/laravel-notification-channels/fcm which would be a better choice. Closing this PR.

@ankurk91
Copy link
Copy Markdown
Contributor

i have released this PR as package
https://github.com/ankurk91/fcm-notification-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants