Skip to content

Commit d8c31f3

Browse files
gshtrasAkshat-Tripathi
authored andcommitted
[ROCm][Quantization][Kernel] Using HIP FP8 header (vllm-project#12593)
1 parent a5f5674 commit d8c31f3

File tree

6 files changed

+267
-634
lines changed

6 files changed

+267
-634
lines changed

CMakeLists.txt

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,25 @@ include(FetchContent)
174174
file(MAKE_DIRECTORY ${FETCHCONTENT_BASE_DIR}) # Ensure the directory exists
175175
message(STATUS "FetchContent base directory: ${FETCHCONTENT_BASE_DIR}")
176176

177+
#
178+
# Set rocm version dev int.
179+
#
180+
if(VLLM_GPU_LANG STREQUAL "HIP")
181+
#
182+
# Overriding the default -O set up by cmake, adding ggdb3 for the most verbose devug info
183+
#
184+
set(CMAKE_${VLLM_GPU_LANG}_FLAGS_DEBUG "${CMAKE_${VLLM_GPU_LANG}_FLAGS_DEBUG} -O0 -ggdb3")
185+
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -O0 -ggdb3")
186+
187+
188+
#
189+
# Certain HIP functions are marked as [[nodiscard]], yet vllm ignores the result which generates
190+
# a lot of warnings that always mask real issues. Suppressing until this is properly addressed.
191+
#
192+
set(CMAKE_${VLLM_GPU_LANG}_FLAGS "${CMAKE_${VLLM_GPU_LANG}_FLAGS} -Wno-unused-result")
193+
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-result")
194+
endif()
195+
177196
#
178197
# Define other extension targets
179198
#

csrc/quantization/fp8/amd/hip_float8.h

Lines changed: 0 additions & 137 deletions
This file was deleted.

0 commit comments

Comments
 (0)