Skip to content

Conversation

@jortel
Copy link
Contributor

@jortel jortel commented Sep 16, 2025

closes #74

An alternative would be for Head() to return the last line in the output.
Thoughts?

Summary by CodeRabbit

  • Bug Fixes
    • Suppressed Git trace output during operations to prevent unexpected verbose logging in normal use.
    • Maintains non-interactive behavior for Git commands, avoiding prompt interruptions.

Signed-off-by: Jeff Ortel <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Sep 16, 2025

Walkthrough

Removed Git tracing environment variables from the command environment in repository/git.go. The function now sets only GIT_TERMINAL_PROMPT=0 and HOME, along with the existing environment. No other logic or control flow was changed.

Changes

Cohort / File(s) Summary
Git command env handling
repository/git.go
Stopped appending GIT_TRACE_SETUP=1 and GIT_TRACE=1 to the environment for git() calls; retained GIT_TERMINAL_PROMPT=0 and HOME.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

Thump-thump, I hop through logs so bright,
Traces gone—now clean as night.
HEAD returns a hash, not chatter,
Quiet carrots—only data that matter.
In burrows of code, I twitch with glee:
Less noise, more commit—hippity!

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7007f00 and 35c65fd.

📒 Files selected for processing (1)
  • repository/git.go (0 hunks)
💤 Files with no reviewable changes (1)
  • repository/git.go
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build-and-upload-for-global-ci

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Pre-merge checks

✅ Passed checks (5 passed)
Check name Status Explanation
Title Check ✅ Passed The title ":bug: Fix trace in commit." is a short, single-sentence summary that directly references the primary change (removing git trace output that appeared in commit/Head) and is clear enough for a reviewer scanning PR history. It succinctly captures the main intent of the changeset.
Linked Issues Check ✅ Passed The change removes the injected GIT_TRACE_SETUP and GIT_TRACE environment variables from git(), which directly addresses linked issue #74's coding objective to stop trace output from appearing in Head()'s commit field; the raw_summary confirms only those trace envars were removed and no other logic was changed. This meets the linked issue requirement to avoid passing trace environment variables to git subprocesses.
Out of Scope Changes Check ✅ Passed Based on the provided raw_summary, the only code change is removal of the GIT_TRACE_SETUP and GIT_TRACE environment variables from the git() invocation; there are no other modifications indicating out-of-scope changes, so the patch appears limited to the linked issue's intent.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

@jortel jortel added this to Planning Sep 16, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Sep 16, 2025
@jortel jortel added this to the v0.8.1 milestone Sep 16, 2025
@jortel jortel requested a review from aufi September 16, 2025 21:30
@jortel jortel added the cherry-pick/release-0.8 This PR should be cherry-picked to release-0.8 branch label Sep 16, 2025
@jortel jortel moved this from 🆕 New to 🔖 Ready in Planning Sep 17, 2025
@jortel jortel merged commit dc842f0 into konveyor:main Oct 23, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Planning Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/release-0.8 This PR should be cherry-picked to release-0.8 branch

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

🐛 Head() returns commit with trace.

2 participants