-
Notifications
You must be signed in to change notification settings - Fork 43
🐛 Add JAVA_PROVIDER_IMAGE variable to install script #480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dylan Murray <[email protected]>
WalkthroughA new environment variable, JAVA_PROVIDER_IMAGE, is added to the install flow (GitHub Action input and install script) and propagated into the Tackle CRD manifest as the spec field provider_java_image_fqin for manifest rendering and deployment. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer / CI
participant Action as Install-tackle Action
participant Script as hack/install-tackle.sh
participant K8s as kubectl / Kubernetes
Dev->>Action: trigger workflow (optional input: java-provider-image)
Action->>Action: set input -> export JAVA_PROVIDER_IMAGE
Action->>Script: run install script (env includes JAVA_PROVIDER_IMAGE)
Script->>Script: render Tackle CRD YAML (set provider_java_image_fqin: JAVA_PROVIDER_IMAGE)
Script->>K8s: kubectl apply -f rendered-crd.yaml
K8s-->>Script: apply result
Script-->>Action: exit status
Action-->>Dev: workflow result
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aufi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be needed add this also to actions inputs https://github.com/konveyor/operator/blob/main/.github/actions/install-tackle/action.yml#L17 to call it from CI, but looks great 👍
Signed-off-by: Dylan Murray <[email protected]>
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a configurable Java provider image: install script and CI action now accept a Java provider image setting. * The deployed Tackle manifest now carries the provider Java image field so deployments use the configured image. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Dylan Murray <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a configurable Java provider image: install script and CI action now accept a Java provider image setting. * The deployed Tackle manifest now carries the provider Java image field so deployments use the configured image. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Dylan Murray <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Dylan Murray <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Dylan Murray <[email protected]>
Summary by CodeRabbit