Skip to content

Conversation

@dymurray
Copy link
Contributor

@dymurray dymurray commented Oct 23, 2025

Summary by CodeRabbit

  • New Features
    • Added a configurable Java provider image: install script and CI action now accept a Java provider image setting.
    • The deployed Tackle manifest now carries the provider Java image field so deployments use the configured image.

@dymurray dymurray added the cherry-pick/release-0.8 This PR should be cherry-picked to release-0.8 branch label Oct 23, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 23, 2025

Walkthrough

A new environment variable, JAVA_PROVIDER_IMAGE, is added to the install flow (GitHub Action input and install script) and propagated into the Tackle CRD manifest as the spec field provider_java_image_fqin for manifest rendering and deployment.

Changes

Cohort / File(s) Summary
Install script
hack/install-tackle.sh
Added JAVA_PROVIDER_IMAGE environment variable with a default value and injected it into the rendered Tackle CRD as provider_java_image_fqin.
GitHub Action inputs / step
.github/actions/install-tackle/action.yml
Added java-provider-image action input (with default) and exported it as JAVA_PROVIDER_IMAGE in the Install tackle run step.

Sequence Diagram(s)

sequenceDiagram
  participant Dev as Developer / CI
  participant Action as Install-tackle Action
  participant Script as hack/install-tackle.sh
  participant K8s as kubectl / Kubernetes

  Dev->>Action: trigger workflow (optional input: java-provider-image)
  Action->>Action: set input -> export JAVA_PROVIDER_IMAGE
  Action->>Script: run install script (env includes JAVA_PROVIDER_IMAGE)
  Script->>Script: render Tackle CRD YAML (set provider_java_image_fqin: JAVA_PROVIDER_IMAGE)
  Script->>K8s: kubectl apply -f rendered-crd.yaml
  K8s-->>Script: apply result
  Script-->>Action: exit status
  Action-->>Dev: workflow result
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A tiny var hopped into the stream,
Passed from Action to script — a seamless dream,
Into the CRD it found its place,
provider_java_image_fqin takes its space,
Hoppity deploy, with a graceful beam 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title ":bug: Add JAVA_PROVIDER_IMAGE variable to install script" accurately describes the primary change in the pull request. The title correctly identifies that a new JAVA_PROVIDER_IMAGE variable is being introduced and is specific about the install script being modified. While the changeset also includes updates to the GitHub Action configuration file (.github/actions/install-tackle/action.yml), these are supporting changes to propagate the variable into the workflow context, with the core logic centered on the install script modification. The title is clear, concise, and non-vague, allowing a developer reviewing the commit history to quickly understand that Java provider image configuration support is being added.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dymurray-patch-3

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a990939 and 03f3f7e.

📒 Files selected for processing (1)
  • .github/actions/install-tackle/action.yml (2 hunks)
🔇 Additional comments (1)
.github/actions/install-tackle/action.yml (1)

21-24: Well-integrated new input parameter.

The java-provider-image input is properly defined and follows existing conventions: kebab-case naming, clear description, sensible default value, and correctly exported as JAVA_PROVIDER_IMAGE environment variable in the install step (line 72). The integration aligns with how other image parameters are handled in this action.

Also applies to: 72-72


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be needed add this also to actions inputs https://github.com/konveyor/operator/blob/main/.github/actions/install-tackle/action.yml#L17 to call it from CI, but looks great 👍

@dymurray dymurray merged commit 1d9ad46 into main Oct 23, 2025
13 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 23, 2025
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added a configurable Java provider image: install script and CI action
now accept a Java provider image setting.
* The deployed Tackle manifest now carries the provider Java image field
so deployments use the configured image.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Dylan Murray <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
dymurray added a commit that referenced this pull request Oct 23, 2025
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added a configurable Java provider image: install script and CI action
now accept a Java provider image setting.
* The deployed Tackle manifest now carries the provider Java image field
so deployments use the configured image.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Dylan Murray <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Dylan Murray <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Dylan Murray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/release-0.8 This PR should be cherry-picked to release-0.8 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants