Skip to content
Draft
Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
c4c672f
Implement import-based search for nodejs.referenced capability
tsanders-rh Nov 20, 2025
cf83ae9
Merge upstream/main into fix/nodejs-referenced-import-search
tsanders-rh Nov 20, 2025
fbf745f
Add comprehensive unit tests for import-based search
tsanders-rh Nov 20, 2025
6eb0d54
Update demo-output.yaml for improved nodejs.referenced precision
tsanders-rh Nov 20, 2025
5b91e1a
Add bounds check before accessing WorkspaceFolders
tsanders-rh Nov 20, 2025
bd53a94
Replace hardcoded sleep with retry logic and exponential backoff
tsanders-rh Nov 20, 2025
9f811ef
Add bounds checks for BaseConfig.WorkspaceFolders access
tsanders-rh Nov 20, 2025
308aee7
Improve escape sequence handling in string parsing
tsanders-rh Nov 20, 2025
ce45ca3
Refine "from" keyword detection with word boundaries
tsanders-rh Nov 20, 2025
db79563
Synchronize BaseConfig.WorkspaceFolders with Config.WorkspaceFolders
tsanders-rh Nov 20, 2025
c777cfb
Limit "from" detection to current import to avoid cross-statement int…
tsanders-rh Nov 20, 2025
e85cc89
Add support for namespace, mixed, and TypeScript type imports
tsanders-rh Nov 20, 2025
dd4a62a
Fix false negative when pattern is prefix of another symbol
tsanders-rh Nov 20, 2025
9219054
Fix test script variable references
tsanders-rh Nov 20, 2025
dfa364b
Remove documentation and test files from repository
tsanders-rh Nov 20, 2025
e139b38
Refactor normalize function with helper methods
tsanders-rh Nov 20, 2025
101422c
Remove public test wrapper methods
tsanders-rh Nov 20, 2025
3f862a2
Respect analysisMode when filtering references
tsanders-rh Nov 20, 2025
b68e524
Build import locations incrementally during file walk
tsanders-rh Nov 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
594 changes: 594 additions & 0 deletions CODE_REVIEW_RESPONSE_PLAN.md

Large diffs are not rendered by default.

1,071 changes: 1,071 additions & 0 deletions NODEJS_REFERENCED_ANALYSIS.md

Large diffs are not rendered by default.

36 changes: 1 addition & 35 deletions demo-output.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -597,44 +597,9 @@
description: Testing that the node provider works - type
category: potential
incidents:
- uri: file:///examples/nodejs/test_a.ts
message: nodejs sample rule 001
codeSnip: " 1 export interface Greeter {\n 2 name: string;\n 3 hello(): string;\n 4 }\n 5 \n 6 export const greeter: Greeter = {\n 7 name: \"Person1\",\n 8 hello() {\n 9 return `Hello, I'm ${this.name}`;\n10 },\n11 };\n"
lineNumber: 5
variables:
file: file:///examples/nodejs/test_a.ts
- uri: file:///examples/nodejs/test_b.ts
message: nodejs sample rule 001
codeSnip: " 1 import { greeter } from './test_a';\n 2 \n 3 console.log(greeter.hello());\n"
lineNumber: 0
variables:
file: file:///examples/nodejs/test_b.ts
- uri: file:///examples/nodejs/test_b.ts
message: nodejs sample rule 001
codeSnip: " 1 import { greeter } from './test_a';\n 2 \n 3 console.log(greeter.hello());\n"
lineNumber: 2
variables:
file: file:///examples/nodejs/test_b.ts
effort: 1
node-sample-rule-002:
description: Testing that the node provider works - function
category: potential
incidents:
- uri: file:///examples/nodejs/test_a.ts
message: nodejs sample rule 002
codeSnip: " 1 export interface Greeter {\n 2 name: string;\n 3 hello(): string;\n 4 }\n 5 \n 6 export const greeter: Greeter = {\n 7 name: \"Person1\",\n 8 hello() {\n 9 return `Hello, I'm ${this.name}`;\n10 },\n11 };\n"
lineNumber: 2
variables:
file: file:///examples/nodejs/test_a.ts
- uri: file:///examples/nodejs/test_a.ts
message: nodejs sample rule 002
codeSnip: " 1 export interface Greeter {\n 2 name: string;\n 3 hello(): string;\n 4 }\n 5 \n 6 export const greeter: Greeter = {\n 7 name: \"Person1\",\n 8 hello() {\n 9 return `Hello, I'm ${this.name}`;\n10 },\n11 };\n"
lineNumber: 7
variables:
file: file:///examples/nodejs/test_a.ts
- uri: file:///examples/nodejs/test_b.ts
message: nodejs sample rule 002
codeSnip: " 1 import { greeter } from './test_a';\n 2 \n 3 console.log(greeter.hello());\n"
lineNumber: 2
variables:
file: file:///examples/nodejs/test_b.ts
Expand Down Expand Up @@ -1353,5 +1318,6 @@
unmatched:
- file-002
- lang-ref-002
- node-sample-rule-002
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK if all of the rule-example rules have this, but can we add a comment explaining why this rule should be unmatched? It helps when we come back later and wonder why it is unmatched and if that was a issue :)

- node-sample-rule-003
- python-sample-rule-003
Loading
Loading