-
Notifications
You must be signed in to change notification settings - Fork 53
✨ Implement import-based search for nodejs.referenced capability #976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 13 commits
c4c672f
cf83ae9
fbf745f
6eb0d54
5b91e1a
bd53a94
9f811ef
308aee7
ce45ca3
db79563
c777cfb
e85cc89
dd4a62a
9219054
dfa364b
e139b38
101422c
3f862a2
b68e524
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -597,44 +597,9 @@ | |
| description: Testing that the node provider works - type | ||
| category: potential | ||
| incidents: | ||
| - uri: file:///examples/nodejs/test_a.ts | ||
| message: nodejs sample rule 001 | ||
| codeSnip: " 1 export interface Greeter {\n 2 name: string;\n 3 hello(): string;\n 4 }\n 5 \n 6 export const greeter: Greeter = {\n 7 name: \"Person1\",\n 8 hello() {\n 9 return `Hello, I'm ${this.name}`;\n10 },\n11 };\n" | ||
| lineNumber: 5 | ||
| variables: | ||
| file: file:///examples/nodejs/test_a.ts | ||
| - uri: file:///examples/nodejs/test_b.ts | ||
| message: nodejs sample rule 001 | ||
| codeSnip: " 1 import { greeter } from './test_a';\n 2 \n 3 console.log(greeter.hello());\n" | ||
| lineNumber: 0 | ||
| variables: | ||
| file: file:///examples/nodejs/test_b.ts | ||
| - uri: file:///examples/nodejs/test_b.ts | ||
| message: nodejs sample rule 001 | ||
| codeSnip: " 1 import { greeter } from './test_a';\n 2 \n 3 console.log(greeter.hello());\n" | ||
| lineNumber: 2 | ||
| variables: | ||
| file: file:///examples/nodejs/test_b.ts | ||
| effort: 1 | ||
| node-sample-rule-002: | ||
| description: Testing that the node provider works - function | ||
| category: potential | ||
| incidents: | ||
| - uri: file:///examples/nodejs/test_a.ts | ||
| message: nodejs sample rule 002 | ||
| codeSnip: " 1 export interface Greeter {\n 2 name: string;\n 3 hello(): string;\n 4 }\n 5 \n 6 export const greeter: Greeter = {\n 7 name: \"Person1\",\n 8 hello() {\n 9 return `Hello, I'm ${this.name}`;\n10 },\n11 };\n" | ||
| lineNumber: 2 | ||
| variables: | ||
| file: file:///examples/nodejs/test_a.ts | ||
| - uri: file:///examples/nodejs/test_a.ts | ||
| message: nodejs sample rule 002 | ||
| codeSnip: " 1 export interface Greeter {\n 2 name: string;\n 3 hello(): string;\n 4 }\n 5 \n 6 export const greeter: Greeter = {\n 7 name: \"Person1\",\n 8 hello() {\n 9 return `Hello, I'm ${this.name}`;\n10 },\n11 };\n" | ||
| lineNumber: 7 | ||
| variables: | ||
| file: file:///examples/nodejs/test_a.ts | ||
| - uri: file:///examples/nodejs/test_b.ts | ||
| message: nodejs sample rule 002 | ||
| codeSnip: " 1 import { greeter } from './test_a';\n 2 \n 3 console.log(greeter.hello());\n" | ||
| lineNumber: 2 | ||
| variables: | ||
| file: file:///examples/nodejs/test_b.ts | ||
|
|
@@ -1353,5 +1318,6 @@ | |
| unmatched: | ||
| - file-002 | ||
| - lang-ref-002 | ||
| - node-sample-rule-002 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. IDK if all of the rule-example rules have this, but can we add a comment explaining why this rule should be unmatched? It helps when we come back later and wonder why it is unmatched and if that was a issue :) |
||
| - node-sample-rule-003 | ||
| - python-sample-rule-003 | ||
Uh oh!
There was an error while loading. Please reload this page.