-
Notifications
You must be signed in to change notification settings - Fork 53
🐛 Pass extra-args to build-push-images #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
WalkthroughThe image-build GitHub Actions workflow now propagates a per-image Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Runner as GitHub Runner
participant ImageBuild as image-build workflow
participant BuildPush as build-push-images workflow
rect #E8F6FF
Note over ImageBuild: Matrix job selected\ncontains `images` entry with `extra-args`
Runner->>ImageBuild: start job (matrix)
end
ImageBuild->>BuildPush: call reusable workflow\nwith inputs including `extra-args: matrix.images.extra-args`
alt extra-args non-empty
BuildPush->>BuildPush: apply supplied extra args\nduring image build
else extra-args empty
BuildPush->>BuildPush: proceed with default build args
end
BuildPush-->>ImageBuild: return status
ImageBuild-->>Runner: job complete
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/image-build.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: test
- GitHub Check: test (windows-latest)
- GitHub Check: benchmark (macos-latest, mac)
- GitHub Check: test (macos-latest)
- GitHub Check: benchmark (windows-latest, windows)
Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
We must pass the `extra-args` argument [to the build-push-images job](https://github.com/konveyor/release-tools/blob/main/.github/workflows/build-push-images.yaml#L27). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Build configuration updated to forward per-image extra arguments into the image build process, allowing custom build flags per image. This improves flexibility for image builds while preserving existing build behavior and defaults. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
We must pass the `extra-args` argument [to the build-push-images job](https://github.com/konveyor/release-tools/blob/main/.github/workflows/build-push-images.yaml#L27). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Build configuration updated to forward per-image extra arguments into the image build process, allowing custom build flags per image. This improves flexibility for image builds while preserving existing build behavior and defaults. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> Signed-off-by: Cherry Picker <[email protected]>
We must pass the `extra-args` argument [to the build-push-images job](https://github.com/konveyor/release-tools/blob/main/.github/workflows/build-push-images.yaml#L27). <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Build configuration updated to forward per-image extra arguments into the image build process, allowing custom build flags per image. This improves flexibility for image builds while preserving existing build behavior and defaults. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Signed-off-by: Juan Manuel Leflet Estrada <[email protected]> Signed-off-by: Cherry Picker <[email protected]> Co-authored-by: Juan Manuel Leflet Estrada <[email protected]>
We must pass the
extra-argsargument to the build-push-images job.Summary by CodeRabbit