Skip to content

Conversation

@jmle
Copy link
Contributor

@jmle jmle commented Oct 22, 2025

We must pass the extra-args argument to the build-push-images job.

Summary by CodeRabbit

  • Chores
    • Build configuration updated to forward per-image extra arguments into the image build process, allowing custom build flags per image. This improves flexibility for image builds while preserving existing build behavior and defaults.

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
@jmle jmle added the cherry-pick/release-0.8 This PR should be cherry-picked to release-0.8 branch label Oct 22, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 22, 2025

Walkthrough

The image-build GitHub Actions workflow now propagates a per-image extra-args value from the job matrix into the called build-push-images reusable workflow by passing matrix.images.extra-args as the extra-args input.

Changes

Cohort / File(s) Summary
Workflow matrix parameter propagation
​.github/workflows/image-build.yaml
Added an extra-args input at the with: level when calling the build-push-images workflow, passing matrix.images.extra-args (defaults to empty string) to enable per-image build arguments.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Runner as GitHub Runner
  participant ImageBuild as image-build workflow
  participant BuildPush as build-push-images workflow

  rect #E8F6FF
    Note over ImageBuild: Matrix job selected\ncontains `images` entry with `extra-args`
    Runner->>ImageBuild: start job (matrix)
  end

  ImageBuild->>BuildPush: call reusable workflow\nwith inputs including `extra-args: matrix.images.extra-args`
  alt extra-args non-empty
    BuildPush->>BuildPush: apply supplied extra args\nduring image build
  else extra-args empty
    BuildPush->>BuildPush: proceed with default build args
  end

  BuildPush-->>ImageBuild: return status
  ImageBuild-->>Runner: job complete
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A little hop through matrix rows,
Extra-args follow where each image goes.
Tiny change, big tidy tune—
Builds now hum beneath the moon. 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title accurately describes the core change of passing extra-args to the build-push-images workflow, but the inclusion of an emoji adds noise and conflicts with the guideline to avoid emojis in titles. Please remove the emoji and use a concise, clear title such as “Pass extra-args to build-push-images” without any additional symbols or noise.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b5291b1 and aff60e1.

📒 Files selected for processing (1)
  • .github/workflows/image-build.yaml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/image-build.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: test
  • GitHub Check: test (windows-latest)
  • GitHub Check: benchmark (windows-latest, windows)
  • GitHub Check: benchmark (macos-latest, mac)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 47df115 and b5291b1.

📒 Files selected for processing (1)
  • .github/workflows/image-build.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: test
  • GitHub Check: test (windows-latest)
  • GitHub Check: benchmark (macos-latest, mac)
  • GitHub Check: test (macos-latest)
  • GitHub Check: benchmark (windows-latest, windows)

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
@jmle jmle merged commit ff18ecd into konveyor:main Oct 23, 2025
17 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 23, 2025
We must pass the `extra-args` argument [to the build-push-images
job](https://github.com/konveyor/release-tools/blob/main/.github/workflows/build-push-images.yaml#L27).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Chores**
* Build configuration updated to forward per-image extra arguments into
the image build process, allowing custom build flags per image. This
improves flexibility for image builds while preserving existing build
behavior and defaults.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
shawn-hurley pushed a commit that referenced this pull request Nov 7, 2025
We must pass the `extra-args` argument [to the build-push-images
job](https://github.com/konveyor/release-tools/blob/main/.github/workflows/build-push-images.yaml#L27).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Chores**
* Build configuration updated to forward per-image extra arguments into
the image build process, allowing custom build flags per image. This
improves flexibility for image builds while preserving existing build
behavior and defaults.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
shawn-hurley pushed a commit that referenced this pull request Nov 20, 2025
We must pass the `extra-args` argument [to the build-push-images

job](https://github.com/konveyor/release-tools/blob/main/.github/workflows/build-push-images.yaml#L27).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Chores**
* Build configuration updated to forward per-image extra arguments into
the image build process, allowing custom build flags per image. This
improves flexibility for image builds while preserving existing build
behavior and defaults.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Signed-off-by: Cherry Picker <[email protected]>
Co-authored-by: Juan Manuel Leflet Estrada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/release-0.8 This PR should be cherry-picked to release-0.8 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants