Skip to content

Commit bd21005

Browse files
authored
🐛 Fix Windows image builds (#963)
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated Windows build infrastructure to use Windows Server LTSC 2025 base images across Windows builds and manifests. * Upgraded Windows build toolchain and runtime bases to newer releases for improved compatibility. * Improved multi-stage Windows image builds and manifest handling. * **New Features** * Windows runtime images now include runtime configuration: the built service runs as the container entrypoint and the service port is exposed. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Jason Montleon <[email protected]>
1 parent f3d48aa commit bd21005

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

.github/workflows/image-build.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ jobs:
102102
shell: bash
103103
run: |
104104
TAG=${GITHUB_REF_NAME/main/latest}
105-
IMAGE_NAME=quay.io/konveyor/analyzer-lsp:${TAG}-windowsservercore-ltsc2022
105+
IMAGE_NAME=quay.io/konveyor/analyzer-lsp:${TAG}-windowsservercore-ltsc2025
106106
docker build -t ${IMAGE_NAME} -f ./Dockerfile.windows .
107107
docker push ${IMAGE_NAME}
108108
@@ -122,7 +122,7 @@ jobs:
122122
shell: bash
123123
run: |
124124
TAG=${GITHUB_REF_NAME/main/latest}
125-
IMAGE_NAME=quay.io/konveyor/dotnet-external-provider:${TAG}-windowsservercore-ltsc2022
125+
IMAGE_NAME=quay.io/konveyor/dotnet-external-provider:${TAG}-windowsservercore-ltsc2025
126126
docker build -t ${IMAGE_NAME} -f ./external-providers/dotnet-external-provider/Dockerfile.windows .
127127
docker push ${IMAGE_NAME}
128128
@@ -136,7 +136,7 @@ jobs:
136136
run: |
137137
podman manifest create temp
138138
podman manifest add temp --all quay.io/konveyor/analyzer-lsp:${tag}
139-
podman manifest add temp --all quay.io/konveyor/analyzer-lsp:${tag}-windowsservercore-ltsc2022
139+
podman manifest add temp --all quay.io/konveyor/analyzer-lsp:${tag}-windowsservercore-ltsc2025
140140
podman tag temp quay.io/konveyor/analyzer-lsp:${tag}
141141
- name: Push manifest to Quay
142142
uses: redhat-actions/push-to-registry@main
@@ -159,7 +159,7 @@ jobs:
159159
run: |
160160
podman manifest create temp
161161
podman manifest add temp --all quay.io/konveyor/dotnet-external-provider:${tag}
162-
podman manifest add temp --all quay.io/konveyor/dotnet-external-provider:${tag}-windowsservercore-ltsc2022
162+
podman manifest add temp --all quay.io/konveyor/dotnet-external-provider:${tag}-windowsservercore-ltsc2025
163163
podman tag temp quay.io/konveyor/dotnet-external-provider:${tag}
164164
- name: Push manifest to Quay
165165
uses: redhat-actions/push-to-registry@main

Dockerfile.windows

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM golang:1.22-windowsservercore-ltsc2022 as builder
1+
FROM golang:1.25-windowsservercore-ltsc2025 as builder
22
WORKDIR /analyzer-lsp
33

44
COPY cmd /analyzer-lsp/cmd
@@ -17,7 +17,7 @@ COPY go.sum /analyzer-lsp/go.sum
1717

1818
RUN go build -o konveyor-analyzer.exe ./cmd/analyzer/main.go
1919

20-
FROM mcr.microsoft.com/windows/servercore:ltsc2022
20+
FROM mcr.microsoft.com/windows/servercore:ltsc2025
2121

2222
# Set the working directory inside the container
2323
WORKDIR C:/app

external-providers/dotnet-external-provider/Dockerfile.windows

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM golang:1.22-windowsservercore-ltsc2022 as builder
1+
FROM golang:1.25-windowsservercore-ltsc2025 as builder
22

33
COPY / /analyzer-lsp
44
WORKDIR /dotnet-provider
@@ -14,7 +14,7 @@ RUN go mod tidy
1414

1515
RUN go build -o bin/dotnet-external-provider.exe main.go
1616

17-
FROM mcr.microsoft.com/dotnet/framework/sdk:4.8
17+
FROM mcr.microsoft.com/dotnet/framework/sdk:4.8.1
1818

1919
RUN dotnet tool install --global csharp-ls --version 0.11.0
2020

0 commit comments

Comments
 (0)