🐛 Updates to socket comms changes (#942)

Author: savitharaghunathan

external-providers/generic-external-provider/Dockerfile

@@ -14,7 +14,7 @@ RUN go mod edit -replace=github.com/konveyor/analyzer-lsp=/analyzer-lsp && go mo
 
 RUN go build -o generic-external-provider main.go && go install golang.org/x/tools/[email protected]
 
-FROM golang-dep-provider as go-dep-provider
+FROM quay.io/konveyor/golang-dependency-provider as go-dep-provider
 
 FROM registry.access.redhat.com/ubi9/ubi-minimal:latest
 

lsp/base_service_client/base_service_client.go

@@ -162,8 +162,8 @@ func NewLSPServiceClientBase(
 		return nil, fmt.Errorf("base config unmarshal error: %w", err)
 	}
 
-	if sc.BaseConfig.LspServerPath == "" {
-		return nil, fmt.Errorf("must provide lspServerPath")
+	if sc.BaseConfig.LspServerPath == "" && c.RPC == nil {
+		return nil, fmt.Errorf("must provide lspServerPath when RPC connection is not provided")
 	}
 
 	if sc.BaseConfig.LspServerName == "" {

provider/grpc/provider.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"io"
 	"os/exec"
+	"strings"
 	"time"
 
 	"github.com/go-logr/logr"
@@ -304,10 +305,21 @@ func start(ctx context.Context, config provider.Config, log logr.Logger) (*grpc.
 	}
 	if config.Address != "" {
 		if config.CertPath == "" {
-			conn, err := grpc.NewClient(fmt.Sprintf(config.Address),
-				grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(socket.MAX_MESSAGE_SIZE)),
-				grpc.WithTransportCredentials(insecure.NewCredentials()),
-			)
+			var conn *grpc.ClientConn
+			var err error
+
+			if config.UseSocket && strings.HasPrefix(config.Address, "unix://") {
+				// Use socket connection
+				// for windows, we will ise passthrough to connect to the socket
+				// which is defined in the socket/pipe_windows.go file
+				conn, err = socket.ConnectGRPC(config.Address)
+			} else {
+				// Use regular HTTP connection
+				conn, err = grpc.NewClient(fmt.Sprintf(config.Address),
+					grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(socket.MAX_MESSAGE_SIZE)),
+					grpc.WithTransportCredentials(insecure.NewCredentials()),
+				)
+			}
 			if err != nil {
 				log.Error(err, "did not connect")
 				return nil, nil, err