Skip to content

Check for non empty union matches #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 28, 2025
Merged

Check for non empty union matches #233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6179619
Check for non empty union matches
kkg4theweb Jun 13, 2023
15a755a
Merge branch 'master' into nounionmatchfix
mciszczon Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dacite/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def _build_value_for_union(union: Type, data: Any, config: Config) -> Any:
return value
except DaciteError:
pass
if config.strict_unions_match:
if config.strict_unions_match and union_matches:
if len(union_matches) > 1:
raise StrictUnionMatchError(union_matches)
return union_matches.popitem()[1]
Expand Down