Skip to content

Commit ab17544

Browse files
committed
Fix the panic
1 parent 5ea54f9 commit ab17544

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

pkg/dashboard/api.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ func configureHelms(api *gin.Engine, data *DataLayer) {
7777
qp, err := getQueryProps(c, false)
7878
if err != nil {
7979
_ = c.AbortWithError(http.StatusBadRequest, err)
80+
return
8081
}
8182
err = data.UninstallChart(qp.Namespace, qp.Name)
8283
if err != nil {
@@ -90,6 +91,7 @@ func configureHelms(api *gin.Engine, data *DataLayer) {
9091
qp, err := getQueryProps(c, true)
9192
if err != nil {
9293
_ = c.AbortWithError(http.StatusBadRequest, err)
94+
return
9395
}
9496

9597
err = data.Revert(qp.Namespace, qp.Name, qp.Revision)
@@ -104,6 +106,7 @@ func configureHelms(api *gin.Engine, data *DataLayer) {
104106
qp, err := getQueryProps(c, false)
105107
if err != nil {
106108
_ = c.AbortWithError(http.StatusBadRequest, err)
109+
return
107110
}
108111

109112
res, err := data.ChartHistory(qp.Namespace, qp.Name)
@@ -118,6 +121,7 @@ func configureHelms(api *gin.Engine, data *DataLayer) {
118121
qp, err := getQueryProps(c, true)
119122
if err != nil {
120123
_ = c.AbortWithError(http.StatusBadRequest, err)
124+
return
121125
}
122126

123127
res, err := data.RevisionManifestsParsed(qp.Namespace, qp.Name, qp.Revision)
@@ -132,13 +136,15 @@ func configureHelms(api *gin.Engine, data *DataLayer) {
132136
qp, err := getQueryProps(c, true)
133137
if err != nil {
134138
_ = c.AbortWithError(http.StatusBadRequest, err)
139+
return
135140
}
136141

137142
flag := c.Query("flag") == "true"
138143
rDiff := c.Query("revisionDiff")
139144
res, err := handleGetSection(data, c.Param("section"), rDiff, qp, flag)
140145
if err != nil {
141146
_ = c.AbortWithError(http.StatusInternalServerError, err)
147+
return
142148
}
143149
c.String(http.StatusOK, res)
144150
})
@@ -195,6 +201,7 @@ func configureKubectls(api *gin.Engine, data *DataLayer) {
195201
qp, err := getQueryProps(c, false)
196202
if err != nil {
197203
_ = c.AbortWithError(http.StatusBadRequest, err)
204+
return
198205
}
199206

200207
res, err := data.GetResource(qp.Namespace, &GenericResource{
@@ -226,6 +233,7 @@ func configureKubectls(api *gin.Engine, data *DataLayer) {
226233
qp, err := getQueryProps(c, false)
227234
if err != nil {
228235
_ = c.AbortWithError(http.StatusBadRequest, err)
236+
return
229237
}
230238

231239
res, err := data.DescribeResource(qp.Namespace, c.Param("kind"), qp.Name)

0 commit comments

Comments
 (0)