Fix analytics is enabled while in dev

undera · undera · commit 8e65c555e09e · 2022-11-24T15:22:50.000Z
diff --git a/pkg/dashboard/server.go b/pkg/dashboard/server.go
@@ -36,7 +36,7 @@ func (s Server) StartServer() (string, utils.ControlChan) {
 		os.Exit(1) // TODO: propagate error instead?
 	}
 	isDevModeWithAnalytics := os.Getenv("HD_DEV_ANALYTICS") == "true"
-	enableAnalytics := !s.NoTracking || isDevModeWithAnalytics
+	enableAnalytics := (!s.NoTracking && s.Version != "0.0.0") || isDevModeWithAnalytics
 	data.StatusInfo = &subproc.StatusInfo{
 		CurVer:             s.Version,
 		Analytics:          enableAnalytics,

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ func (s Server) StartServer() (string, utils.ControlChan) {`
`36`	`36`	`os.Exit(1) // TODO: propagate error instead?`
`37`	`37`	`}`
`38`	`38`	`isDevModeWithAnalytics := os.Getenv("HD_DEV_ANALYTICS") == "true"`
`39`		`- enableAnalytics := !s.NoTracking \|\| isDevModeWithAnalytics`
	`39`	`+ enableAnalytics := (!s.NoTracking && s.Version != "0.0.0") \|\| isDevModeWithAnalytics`
`40`	`40`	`data.StatusInfo = &subproc.StatusInfo{`
`41`	`41`	`CurVer: s.Version,`
`42`	`42`	`Analytics: enableAnalytics,`