feat: Improve fail progress message #64

koki-develop · 2025-04-05T03:43:55Z

No description provided.

gemini-code-assist

Hello @koki-develop, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request enhances the error handling and progress reporting in the build and install processes. Specifically, it introduces a fail status to the progress indicator, allowing users to see which workflows or actions failed during the build or install process. The changes also involve refactoring the import paths for getFileContent and getCommit to use the ../lib/github path instead of ../../internal/git.

Highlights

Error Handling: The pull request adds a try...catch block around the _buildWorkflow call in lib/cli/build/index.tsx to catch errors and report them using the new fail status in the progress indicator.
Progress Reporting: A fail status is added to the progress indicator in lib/cli/ui/Progress.tsx to visually indicate when a build or install step has failed.
Import Path Refactoring: The pull request updates import paths for getFileContent and getCommit in lib/cli/install/action-yaml.ts and lib/cli/install/commit.ts to use ../lib/github.
Install Process Error Handling: The pull request adds a try...catch block around the action installation logic in lib/cli/install/index.tsx to catch errors and report them using the new fail status.

Changelog

Click here to see the changelog

lib/cli/build/index.tsx
- Added a try...catch block to handle errors during workflow building.
- Introduced the fail function from the progress indicator to report failed workflows.
lib/cli/install/action-yaml.ts
- Updated the import path for getFileContent to ../lib/github.
lib/cli/install/commit.ts
- Updated the import path for getCommit to ../lib/github.
lib/cli/install/index.tsx
- Added a try...catch block to handle errors during action installation.
- Introduced the fail function from the progress indicator to report failed actions.
lib/cli/install/type-def.ts
- Updated the import path for toUpperCamelCase to ../lib/util.
lib/cli/ui/Progress.tsx
- Added a fail status to the ProgressStatus type.
- Implemented visual representation for the fail status using a red '✗' symbol.
- Added a fail function to the progress indicator to trigger the fail status.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

A red 'X' now appears,
When builds crash down in tears,
Progress shown with care,
Failures now laid bare,
Debugging conquers fears.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copilot

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

lib/cli/ui/Progress.tsx:39

[nitpick] The arrow function parameter 'title' shadows the outer 'title' prop. Consider renaming it (for example, to 'item') to enhance code clarity.

{(title) => (

gemini-code-assist

Code Review

The pull request introduces a new fail state to the progress indicator, enhancing the user experience by providing visual feedback when build or installation processes encounter errors. The changes are well-structured and improve the clarity of error handling.

Merge Readiness

The code changes are well-implemented and enhance the user experience by providing clear feedback on failures. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging. The changes look good and I recommend merging this pull request.

gemini-code-assist · 2025-04-05T03:44:12Z

lib/cli/build/index.tsx

+        await _buildWorkflow(workflowPath);
+        await done(getBuildTargetPath(workflowPath));
+      } catch (error) {
+        await fail(workflowPath);


Consider adding more context to the fail message, such as the specific error that occurred. This would help users diagnose issues more effectively.

Suggested change

await fail(workflowPath);

await fail(`${workflowPath} - ${error.message}`);

gemini-code-assist · 2025-04-05T03:44:13Z

lib/cli/install/index.tsx

+
+        await done(`${parsedAction.fullName}@${tagName}`);
+      } catch (error) {
+        await fail(`${parsedAction.fullName}@${parsedAction.version}`);


Similar to the build process, adding the error message to the fail message would provide more context to the user.

Suggested change

await fail(`${parsedAction.fullName}@${parsedAction.version}`);

await fail(`${parsedAction.fullName}@${parsedAction.version} - ${error.message}`);

codecov · 2025-04-05T03:44:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (0729fb1) to head (dc0cefb).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files          15       15           
  Lines         581      581           
=======================================
  Hits          570      570           
  Misses         11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

koki-develop added 4 commits April 5, 2025 12:24

chore: Implement error function

d7b4014

chore: error -> fail

0e95d00

feat: Show fail progress message

38aff5f

chore: Move files

dc0cefb

koki-develop requested a review from Copilot April 5, 2025 03:43

koki-develop self-assigned this Apr 5, 2025

gemini-code-assist bot reviewed Apr 5, 2025

View reviewed changes

Copilot AI reviewed Apr 5, 2025

View reviewed changes

gemini-code-assist bot reviewed Apr 5, 2025

View reviewed changes

koki-develop merged commit 7574e23 into main Apr 5, 2025
5 checks passed

koki-develop deleted the fail-progress branch April 5, 2025 03:45

github-actions bot mentioned this pull request Apr 5, 2025

chore(main): release 0.9.0 #65

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Improve fail progress message #64

feat: Improve fail progress message #64

Uh oh!

koki-develop commented Apr 5, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Apr 5, 2025

Uh oh!

gemini-code-assist bot Apr 5, 2025

Uh oh!

codecov bot commented Apr 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	await fail(workflowPath);
	await fail(`${workflowPath} - ${error.message}`);

	await fail(`${parsedAction.fullName}@${parsedAction.version}`);
	await fail(`${parsedAction.fullName}@${parsedAction.version} - ${error.message}`);

feat: Improve fail progress message #64

feat: Improve fail progress message #64

Uh oh!

Conversation

koki-develop commented Apr 5, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Changelog

Footnotes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Merge Readiness

Uh oh!

gemini-code-assist bot Apr 5, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 5, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Apr 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Apr 5, 2025 •

edited

Loading