Skip to content

Conversation

@imjasonh
Copy link
Member

Followup on #38

@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2020

Codecov Report

Merging #211 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   37.15%   37.23%   +0.07%     
==========================================
  Files          33       33              
  Lines        1405     1402       -3     
==========================================
  Hits          522      522              
+ Misses        793      790       -3     
  Partials       90       90              
Impacted Files Coverage Δ
pkg/commands/apply.go 0.00% <0.00%> (ø)
pkg/commands/create.go 0.00% <0.00%> (ø)
pkg/commands/resolve.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27676b1...a32ced2. Read the comment docs.

@jonjohnsonjr
Copy link
Collaborator

I have seen a lot of folks referencing the --platform=amd64 syntax, which won't work (has been corrected in this PR). If people don't like having to --platform=linux/amd64, we should talk about that now before this implementation ossifies.

@imjasonh
Copy link
Member Author

I have seen a lot of folks referencing the --platform=amd64 syntax, which won't work (has been corrected in this PR). If people don't like having to --platform=linux/amd64, we should talk about that now before this implementation ossifies.

I think it's fine the way it is. I don't expect people to really use anything besides "all platforms" or "my current platform" in practice.

@mattmoor mattmoor merged commit 3691164 into ko-build:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants