Revert "step4 - [클로드코드리뷰] LinesFactoryBean->LinesFactory네이밍 변경 Bean은 Spring의 FactoryBean 패턴과 혼동됨"

This reverts commit 975928a.

Author: kimsuyeondev

src/main/java/engine/LinesCreator.java

@@ -1,10 +1,12 @@
 package engine;
 
 import nextstep.ladder.domain.Line;
+import nextstep.ladder.strategy.LineStrategy;
 
 import java.util.List;
 
 
 public interface LinesCreator {
+    void generateLine(int participantCnt, int maxLadder, LineStrategy lineStrategy);
     List<Line> getLines();
 }

src/main/java/factory/LinesFactory.java

@@ -0,0 +1,15 @@
+package factory;
+
+import engine.LinesCreator;
+import nextstep.ladder.domain.NextStepLines;
+import nextstep.ladder.strategy.LineStrategy;
+
+public class LinesFactoryBean {
+
+    public static LinesCreator createNextStepLadderFactory(int size, int maxLadder, LineStrategy lineStrategy) {
+        NextStepLines nextStepLines = new NextStepLines();
+        nextStepLines.generateLine(size, maxLadder, lineStrategy);
+        return nextStepLines;
+    }
+
+}

src/main/java/factory/LinesFactoryBean.java

@@ -1,7 +1,7 @@
 package nextstep.ladder.controller;
 
 import engine.LinesCreator;
-import factory.LinesFactory;
+import factory.LinesFactoryBean;
 import nextstep.ladder.domain.LadderExecutor;
 import nextstep.ladder.domain.ExecuteResult;
 import nextstep.ladder.domain.LadderResult;
@@ -29,7 +29,7 @@ public void startLadder() {
 
         ExecuteResult executeResult = new ExecuteResult(participants.size(), executeResultStr);
 
-        LinesCreator linesCreator = LinesFactory.createNextStepLines(participants.size(), maxLadder, new LadderLineStrategy());
+        LinesCreator linesCreator = LinesFactoryBean.createNextStepLadderFactory(participants.size(), maxLadder, new LadderLineStrategy());
 
         LadderExecutor ladderExecutor = new LadderExecutor(linesCreator, participants);
         MachingResult machingResult = ladderExecutor.play();

src/main/java/nextstep/ladder/controller/LadderController.java

@@ -9,16 +9,15 @@
 public class NextStepLines implements LinesCreator {
     private final List<Line> lines;
 
-    public NextStepLines(int participantCnt, int maxLadder, LineStrategy lineStrategy) {
-        this.lines = new ArrayList<>();
-        generateLine(participantCnt, maxLadder, lineStrategy);
+    public NextStepLines() {
+        this(new ArrayList<Line>());
     }
 
     public NextStepLines(ArrayList<Line> lines) {
         this.lines = new ArrayList<>(lines);
     }
 
-    private void generateLine(int participantCnt, int maxLadder, LineStrategy lineStrategy) {
+    public void generateLine(int participantCnt, int maxLadder, LineStrategy lineStrategy) {
         for (int i = 0; i < maxLadder; i++) {
             generateLine(participantCnt, lineStrategy);
         }
@@ -29,7 +28,6 @@ private void generateLine(int participantCnt, LineStrategy lineStrategy) {
         lines.add(line);
     }
 
-    @Override
     public List<Line> getLines() {
         return lines;
     }

src/main/java/nextstep/ladder/domain/NextStepLines.java

@@ -1,6 +1,6 @@
 package engine;
 
-import factory.LinesFactory;
+import factory.LinesFactoryBean;
 import nextstep.ladder.domain.LadderExecutor;
 import nextstep.ladder.domain.MachingResult;
 import nextstep.ladder.domain.Participants;
@@ -9,11 +9,11 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-public class LinesFactoryTest {
+public class LinesFactoryBeanTest {
 
     @Test
-    void createNextStepLines() {
-        LinesCreator linesCreator = LinesFactory.createNextStepLines(3, 5, new TrueLineStrategy());
+    void createNextStepLadderFactory() {
+        LinesCreator linesCreator = LinesFactoryBean.createNextStepLadderFactory(3, 5, new TrueLineStrategy());
         Participants participants = new Participants("a,b,c");
         LadderExecutor ladderExecutor = new LadderExecutor(linesCreator, participants);
         MachingResult machingResult = ladderExecutor.play();

…c/test/java/engine/LinesFactoryTest.java …st/java/engine/LinesFactoryBeanTest.javasrc/test/java/engine/LinesFactoryTest.java renamed to src/test/java/engine/LinesFactoryBeanTest.java src/test/java/engine/LinesFactoryTest.java renamed to src/test/java/engine/LinesFactoryBeanTest.java

@@ -10,13 +10,16 @@ class NextStepLinesTest {
 
     public static NextStepLines lines() {
         LineStrategy lineStrategy = new TrueLineStrategy();
-        return new NextStepLines(4, 3, lineStrategy);
+        NextStepLines nextStepLines = new NextStepLines();
+        nextStepLines.generateLine(4, 3, lineStrategy);
+        return nextStepLines;
     }
 
     @Test
     void 세명의참가자만큼_네줄로_사다리_생성() {
         LineStrategy lineStrategy = new TrueLineStrategy();
-        NextStepLines nextStepLines = new NextStepLines(3, 4, lineStrategy);
+        NextStepLines nextStepLines = new NextStepLines();
+        nextStepLines.generateLine(3, 4, lineStrategy);
 
         assertThat(nextStepLines.size()).isEqualTo(4);
         for (int i = 0; i < nextStepLines.size(); i++) {