[MBL-2962] Add ppo v3/v4 analytics and fix incorrect total count (#2751)

* Add new analytics

* Fix total count

* Add comment explaining total count

Author: ifosli

Kickstarter-Framework/Sources/Kickstarter-Framework/Kickstarter-iOS/Features/PledgedProjectsOverview/PPOViewModel.swift

@@ -164,7 +164,7 @@ final class PPOViewModel: ObservableObject, PPOViewModelInputs, PPOViewModelOutp
     let latestLoadedResults = self.paginator.$results
       .compactMap { results in
         results.hasLoaded ? results.values
-          .ppoAnalyticsProperties(total: results.total, page: results.page) : nil
+          .ppoAnalyticsProperties(page: results.page) : nil
       }
 
     // Analytics: When view appears, the next time it loads, send a PPO dashboard open
@@ -255,8 +255,10 @@ final class PPOViewModel: ObservableObject, PPOViewModelInputs, PPOViewModelOutp
         properties: overallProperties
       )
     case .manageLivePledge:
-      // TODO(MBL-2962): Add analytics event.
-      break
+      AppEnvironment.current.ksrAnalytics.trackPPOManageLivePledge(
+        project: cardModel.projectAnalytics,
+        properties: overallProperties
+      )
     }
   }
 
@@ -372,14 +374,16 @@ final class PPOViewModel: ObservableObject, PPOViewModelInputs, PPOViewModelOutp
 }
 
 extension Sequence where Element == PPOProjectCardViewModel {
-  func ppoAnalyticsProperties(total: Int?, page: Int?) -> KSRAnalytics.PledgedProjectOverviewProperties {
+  func ppoAnalyticsProperties(page: Int?) -> KSRAnalytics.PledgedProjectOverviewProperties {
     var paymentFailedCount: Int = 0
     var cardAuthRequiredCount: Int = 0
     var surveyAvailableCount: Int = 0
     var addressLocksSoonCount: Int = 0
     var pledgeManagementCount: Int = 0
 
     var fundedProjectCount: Int = 0
+    var liveProjectCount: Int = 0
+    var unsuccessfulPledgeCount: Int = 0
 
     for viewModel in self {
       switch viewModel.card.tierType {
@@ -396,11 +400,9 @@ extension Sequence where Element == PPOProjectCardViewModel {
       case .surveySubmitted, .pledgeCollected, .addressConfirmed, .awaitingReward, .rewardReceived:
         fundedProjectCount += 1
       case .campaignLive, .campaignFunded, .campaignEnded:
-        // TODO(MBL-2962): Add analytics for live projects.
-        continue
+        liveProjectCount += 1
       case .campaignFailed, .pledgeDropped, .pledgeCanceled:
-        // TODO(MBL-2962): Add analytics for failed/canceled pledges.
-        continue
+        unsuccessfulPledgeCount += 1
       }
     }
 
@@ -411,7 +413,8 @@ extension Sequence where Element == PPOProjectCardViewModel {
       paymentFailedCount: paymentFailedCount,
       cardAuthRequiredCount: cardAuthRequiredCount,
       fundedProjectCount: fundedProjectCount,
-      total: total,
+      liveProjectCount: liveProjectCount,
+      unsuccessfulPledgeCount: unsuccessfulPledgeCount,
       page: page
     )
   }

Library/Sources/Library/Library/Paginator.swift

@@ -231,6 +231,10 @@ public class Paginator<Envelope, Value: Equatable, Cursor: Equatable, SomeError:
         if allValues.count == 0 {
           results = .empty
         } else if let nextCursor, !newValues.isEmpty {
+          // Warning: This total count may be incorrect. It should represent the total number of
+          // cards that a user has, but because of the way the fetch works on the backend, that
+          // number is currently unknown. The backend returns the number of cards in the fetch
+          // itself instead.
           let total = self.totalFromEnvelope(envelope)
           results = .someLoaded(values: allValues, cursor: nextCursor, total: total, page: newPage)
         } else {

Library/Sources/Library/Library/Tracking/KSRAnalytics.swift

@@ -154,6 +154,7 @@ public final class KSRAnalytics {
     case logInOrSignUp
     case logInSubmit
     case messageCreatorInitiate
+    case nativeManagePledge
     case pledgeConfirm
     case pledgeInitiate
     case pledgeSubmit
@@ -193,6 +194,7 @@ public final class KSRAnalytics {
       case .fixPledgeInitiate: return "fix_pledge_initiate"
       case .forgotPassword: return "forgot_password"
       case .messageCreatorInitiate: return "message_creator_initiate"
+      case .nativeManagePledge: return "native_manage_pledge"
       case .onboardingClose: return "close"
       case .onboardingNext: return "next"
       case .onboardingGetNotified: return "get_notified"
@@ -573,7 +575,8 @@ public final class KSRAnalytics {
     let paymentFailedCount: Int
     let cardAuthRequiredCount: Int
     let fundedProjectCount: Int
-    let total: Int?
+    let liveProjectCount: Int
+    let unsuccessfulPledgeCount: Int
     let page: Int?
 
     var alertCardCount: Int {
@@ -584,14 +587,24 @@ public final class KSRAnalytics {
         self.cardAuthRequiredCount
     }
 
+    // Calculate the total number of cards that have been fetched.
+    // This ensures the total count is consistent with other counts.
+    var total: Int {
+      return self.alertCardCount +
+        self.fundedProjectCount +
+        self.liveProjectCount +
+        self.unsuccessfulPledgeCount
+    }
+
     public init(
       addressLocksSoonCount: Int,
       surveyAvailableCount: Int,
       pledgeManagementCount: Int,
       paymentFailedCount: Int,
       cardAuthRequiredCount: Int,
       fundedProjectCount: Int,
-      total: Int?,
+      liveProjectCount: Int,
+      unsuccessfulPledgeCount: Int,
       page: Int?
     ) {
       self.addressLocksSoonCount = addressLocksSoonCount
@@ -600,7 +613,8 @@ public final class KSRAnalytics {
       self.paymentFailedCount = paymentFailedCount
       self.cardAuthRequiredCount = cardAuthRequiredCount
       self.fundedProjectCount = fundedProjectCount
-      self.total = total
+      self.liveProjectCount = liveProjectCount
+      self.unsuccessfulPledgeCount = unsuccessfulPledgeCount
       self.page = page
     }
   }
@@ -802,6 +816,23 @@ public final class KSRAnalytics {
     )
   }
 
+  public func trackPPOManageLivePledge(
+    project: any ProjectAnalyticsProperties,
+    properties: PledgedProjectOverviewProperties
+  ) {
+    let props = contextProperties(
+      ctaContext: .nativeManagePledge,
+      page: .projectAlerts
+    )
+    .withAllValuesFrom(projectProperties(from: project))
+    .withAllValuesFrom(pledgedProjectOverviewProperties(from: properties))
+
+    self.track(
+      event: SegmentEvent.ctaClicked.rawValue,
+      properties: props
+    )
+  }
+
   public func trackPPOViewProjectDetails(
     project: any ProjectAnalyticsProperties,
     properties: PledgedProjectOverviewProperties
@@ -1762,11 +1793,10 @@ private func pledgedProjectOverviewProperties(
 
   result["notification_count_alert_card"] = properties.alertCardCount
   result["notification_count_funded_project"] = properties.fundedProjectCount
+  result["notification_count_live_project"] = properties.liveProjectCount
+  result["notification_count_unsuccessful_pledge"] = properties.unsuccessfulPledgeCount
 
-  if let total = properties.total {
-    result["notification_count_total"] = total
-  }
-
+  result["notification_count_total"] = properties.total
   if let page = properties.page {
     result["context_page_number"] = page
   }