Skip to content

Commit b00c418

Browse files
npolshakovajenshu
andauthored
Initial codeowners (#138)
* initial codeowners Signed-off-by: npolshakova <[email protected]> * feedback Signed-off-by: npolshakova <[email protected]> * Apply suggestion from @jenshu Signed-off-by: Jenny Shu <[email protected]> * Apply suggestion from @jenshu Signed-off-by: Jenny Shu <[email protected]> * Apply suggestion Signed-off-by: Jenny Shu <[email protected]> --------- Signed-off-by: npolshakova <[email protected]> Signed-off-by: Jenny Shu <[email protected]> Co-authored-by: Jenny Shu <[email protected]>
1 parent ff98d09 commit b00c418

2 files changed

Lines changed: 32 additions & 3 deletions

File tree

CONTRIBUTOR_LADDER.md

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ To apply to become a member of the kgateway-dev organization on GitHub, please o
5050
1. Use the [membership request template](.github/PULL_REQUEST_TEMPLATE/apply_to_be_a_member.md). This template is linked from the default template when you open a PR, or you can paste this URL in your browser `https://github.com/kgateway-dev/community/compare/main...<my-fork>:<my-branch>?quick_pull=1&title=Request%20org%20membership%20for%20<user>&labels=membership&template=apply_to_be_a_member.md`, replacing:
5151
- `<my-fork>:<my-branch>` with your fork/branch name, and
5252
- `<user>` with your GitHub username
53-
1. Add your GitHub username to the list of members (under `orgs.kgateway-dev.members` and `orgs.kgateway-dev.teams.org-members.members`) in our [organization file](./org.yaml). Please add your name in the correct alphabetical order to maintain a tidy organization file.
53+
2. Add your GitHub username to the list of members (under `orgs.kgateway-dev.members` and `orgs.kgateway-dev.teams.org-members.members`) in our [organization file](./org.yaml). Please add your name in the correct alphabetical order to maintain a tidy organization file.
5454

5555
### Maintainer
5656

@@ -75,11 +75,20 @@ A Maintainer must meet the responsibilities and requirements of an Organization
7575

7676
Any current Maintainer may nominate a current Organization Member to become a new Maintainer in one or more repositories, by opening a PR in the community repository using the [maintainer nomination template](.github/PULL_REQUEST_TEMPLATE/nominate_a_maintainer.md). The following requirements must be met before the PR is merged:
7777
1. Each item in the template checklist must be satisfied.
78-
1. At least 2 current Maintainers from each relevant repository must approve the PR.
79-
1. There must be no objections from other maintainers. This can be achieved by either of the following, whichever occurs first:
78+
2. At least 2 current Maintainers from each relevant repository must approve the PR.
79+
3. There must be no objections from other maintainers. This can be achieved by either of the following, whichever occurs first:
8080
* Leaving the PR open for one week with no objections
8181
* Asking at the weekly community meeting whether there are any objections
8282

83+
### Becoming a CODEOWNER
84+
85+
You must already be a Maintainer of kgateway to become a CODEOWNER.
86+
87+
1. Review at least 5 PRs and author 5 PRs in the repository under the specific CODEOWNERS group
88+
2. Get nominated by an existing CODEOWNER of that group and update the org.yaml and get a +1 from another CODEOWNER
89+
90+
Additional specific CODEOWNER requirements can be decided by the CODEOWNER group and the community as needed.
91+
8392
## Inactivity
8493

8594
It is important for contributors to be and stay active to set an example and show commitment to the project. Inactivity is harmful to the project as it may lead to unexpected delays, contributor attrition, and a lost of trust in the project.

org.yaml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,26 @@ orgs:
117117
privacy: closed
118118
repos:
119119
kgateway.dev: maintain
120+
kgateway-api-owners:
121+
description: Maintainers of the kgateway envoy API
122+
maintainers:
123+
- howardjohn
124+
- jenshu
125+
- lgadban
126+
- shashankram
127+
- timflannagan
128+
- yuval-k
129+
privacy: closed
130+
agentgateway-api-owners:
131+
description: Maintainers of the kgateway agentgateway API
132+
maintainers:
133+
- howardjohn
134+
- jenshu
135+
- lgadban
136+
- npolshakova
137+
- shashankram
138+
- yuval-k
139+
privacy: closed
120140
eligible-voters:
121141
description: ""
122142
maintainers:

0 commit comments

Comments
 (0)