use default flavor if there is no product flavor #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legion2
commented
Sep 18, 2021
| ProductFlavor flavor = variant.productFlavors.isEmpty() ? variant.mergedFlavor : variant.productFlavors.first() | ||
| flavor.missingDimensionStrategies.find { entry -> | ||
| String toDimension = entry.getKey() | ||
| String toFlavor = entry.getValue().getFallbacks().first() |
Contributor
Author
There was a problem hiding this comment.
@kezong should't we first try the requested value and then try all the fallbacks?
Suggested change
| String toFlavor = entry.getValue().getFallbacks().first() | |
| String toFlavor = entry.getValue().requested |
Because the semantic of missingDimensionStrategy is as follows:
missingDimensionStrategy 'dimension', 'requested', 'fallback1', 'fallback2' ...
getFallbacks().first() would select fallback1 and skipping requested and ignoring the other fallbacks.
As a result missingDimensionStrategy 'dimension', 'requested' causes an exception, because it has not fallbacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the
mergedFlavorif there are noproductFlavors. This allows to usemissingDimensionStrategyin thedefaultConfig.fixed #343