fix flag defaults

Author: dcousens

packages/core/src/scripts/cli.ts

@@ -17,15 +17,23 @@ export type Flags = {
 };
 
 function defaultFlags(flags: Partial<Flags>, defaults: Partial<Flags>) {
+  flags = { ...defaults, ...flags };
+
   for (const [key, value] of Object.entries(flags)) {
-    if (!(key in defaults)) throw new Error(`Option '${key}' is unsupported for this command`);
+    if (value !== undefined && !(key in defaults)) {
+      throw new Error(`Option '${key}' is unsupported for this command`);
+    }
 
+    const defaultValue = defaults[key as keyof Flags];
     // should we default the flag?
     if (value === undefined) {
-      flags[key as keyof Flags] = defaults[key as keyof Flags];
+      flags[key as keyof Flags] = defaultValue;
     }
-  }
 
+    if (typeof value !== typeof defaultValue) {
+      throw new Error(`Option '${key}' should be of type ${typeof defaultValue}`);
+    }
+  }
   return flags as Flags;
 }
 
@@ -65,16 +73,6 @@ export async function cli(cwd: string, argv: string[]) {
         trigger prisma to run migrations as part of startup
     `,
     {
-      allowUnknownFlags: false,
-      flags: {
-        dbPush: { type: 'boolean' },
-        frozen: { type: 'boolean' },
-        prisma: { type: 'boolean' },
-        server: { type: 'boolean' },
-        ui: { type: 'boolean' },
-        withMigrations: { type: 'boolean' },
-        fix: { type: 'boolean' }, // TODO: remove - deprecated
-      },
       argv,
     }
   );