Skip to content

Commit 192fd8e

Browse files
committed
tidy up circular comments
1 parent f52f12c commit 192fd8e

File tree

5 files changed

+3
-8
lines changed

5 files changed

+3
-8
lines changed

packages/core/src/scripts/build.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,7 @@ export async function build (
2121
// TODO: should this happen if frozen?
2222
await esbuild.build(getEsbuildConfig(cwd))
2323

24-
// TODO: this cannot be changed for now, circular dependency with getSystemPaths, getEsbuildConfig
2524
const system = createSystem(await importBuiltKeystoneConfiguration(cwd))
26-
2725
if (prisma) {
2826
if (frozen) {
2927
await validateArtifacts(cwd, system)

packages/core/src/scripts/dev.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ export async function dev (
125125

126126
if (exit) throw new ExitError(1)
127127
}
128-
// TODO: this cannot be changed for now, circular dependency with getSystemPaths, getEsbuildConfig
128+
129129
const app = server ? express() : null
130130
const httpServer = app ? createServer(app) : null
131131
let expressServer: express.Express | null = null

packages/core/src/scripts/migrate.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,7 @@ export async function migrateCreate (
5858
) {
5959
await esbuild.build(getEsbuildConfig(cwd))
6060

61-
// TODO: this cannot be changed for now, circular dependency with getSystemPaths, getEsbuildConfig
6261
const system = createSystem(await importBuiltKeystoneConfiguration(cwd))
63-
6462
if (frozen) {
6563
await validateArtifacts(cwd, system)
6664
console.log('✨ GraphQL and Prisma schemas are up to date')

packages/core/src/scripts/prisma.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,7 @@ async function spawnPrisma3 (cwd: string, system: {
3434
export async function prisma (cwd: string, args: string[], frozen: boolean) {
3535
// TODO: should build unless --frozen?
3636

37-
// TODO: this cannot be changed for now, circular dependency with getSystemPaths, getEsbuildConfig
38-
const config = await importBuiltKeystoneConfiguration(cwd)
39-
const system = createSystem(config)
37+
const system = createSystem(await importBuiltKeystoneConfiguration(cwd))
4038

4139
await validateArtifacts(cwd, system)
4240
console.log('✨ GraphQL and Prisma schemas are up to date')

packages/core/src/scripts/utils.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ export class ExitError extends Error {
88
}
99
}
1010

11+
// TODO: this cannot be changed for now, circular dependency with getSystemPaths, getEsbuildConfig
1112
export async function importBuiltKeystoneConfiguration (cwd: string) {
1213
try {
1314
return require(getBuiltKeystoneConfigurationPath(cwd)).default

0 commit comments

Comments
 (0)