docs(skills): enhance pr-creator safety and interactivity (google-gemini#18616)

Author: NTaylorMullen

packages/cli/src/ui/components/AskUserDialog.tsx

@@ -819,7 +819,6 @@ const ChoiceQuestionView: React.FC<ChoiceQuestionViewProps> = ({
         items={selectionItems}
         onSelect={handleSelect}
         onHighlight={handleHighlight}
-        focusKey={isCustomOptionFocused ? 'other' : undefined}
         maxItemsToShow={maxItemsToShow}
         showScrollArrows={true}
         renderItem={(item, context) => {

packages/cli/src/ui/components/Header.test.tsx

@@ -10,13 +10,17 @@ import { Header } from './Header.js';
 import * as useTerminalSize from '../hooks/useTerminalSize.js';
 import { longAsciiLogo } from './AsciiArt.js';
 import * as semanticColors from '../semantic-colors.js';
+import * as terminalSetup from '../utils/terminalSetup.js';
 import { Text } from 'ink';
 import type React from 'react';
 
 vi.mock('../hooks/useTerminalSize.js');
 vi.mock('../hooks/useSnowfall.js', () => ({
   useSnowfall: vi.fn((art) => art),
 }));
+vi.mock('../utils/terminalSetup.js', () => ({
+  getTerminalProgram: vi.fn(),
+}));
 vi.mock('ink-gradient', () => {
   const MockGradient = ({ children }: { children: React.ReactNode }) => (
     <>{children}</>
@@ -37,6 +41,7 @@ vi.mock('ink', async () => {
 describe('<Header />', () => {
   beforeEach(() => {
     vi.clearAllMocks();
+    vi.mocked(terminalSetup.getTerminalProgram).mockReturnValue(null);
   });
 
   it('renders the long logo on a wide terminal', () => {
@@ -66,13 +71,24 @@ describe('<Header />', () => {
     );
   });
 
+  it('renders custom ASCII art as is when running in an IDE', () => {
+    const customArt = 'CUSTOM ART';
+    vi.mocked(terminalSetup.getTerminalProgram).mockReturnValue('vscode');
+    render(
+      <Header version="1.0.0" nightly={false} customAsciiArt={customArt} />,
+    );
+    expect(Text).toHaveBeenCalledWith(
+      expect.objectContaining({
+        children: customArt,
+      }),
+      undefined,
+    );
+  });
+
   it('displays the version number when nightly is true', () => {
     render(<Header version="1.0.0" nightly={true} />);
     const textCalls = (Text as Mock).mock.calls;
-    const versionText = Array.isArray(textCalls[1][0].children)
-      ? textCalls[1][0].children.join('')
-      : textCalls[1][0].children;
-    expect(versionText).toBe('v1.0.0');
+    expect(textCalls[1][0].children.join('')).toBe('v1.0.0');
   });
 
   it('does not display the version number when nightly is false', () => {
@@ -106,6 +122,7 @@ describe('<Header />', () => {
         comment: '',
         symbol: '',
         dark: '',
+        focus: '',
         gradient: undefined,
       },
       status: {

packages/cli/src/ui/components/SessionBrowser.tsx

@@ -8,6 +8,7 @@ import type React from 'react';
 import { useState, useCallback, useMemo, useEffect, useRef } from 'react';
 import { Box, Text } from 'ink';
 import { Colors } from '../colors.js';
+import { theme } from '../semantic-colors.js';
 import { useTerminalSize } from '../hooks/useTerminalSize.js';
 import { useKeypress } from '../hooks/useKeypress.js';
 import path from 'node:path';
@@ -436,7 +437,7 @@ const SessionItem = ({
     if (isDisabled) {
       return Colors.Gray;
     }
-    return isActive ? Colors.AccentPurple : c;
+    return isActive ? theme.ui.focus : c;
   };
 
   const prefix = isActive ? '❯ ' : '  ';
@@ -775,12 +776,10 @@ export const useSessionBrowserInput = (
           state.setSearchQuery('');
           state.setActiveIndex(0);
           state.setScrollOffset(0);
-          return true;
         } else if (key.name === 'backspace') {
           state.setSearchQuery((prev) => prev.slice(0, -1));
           state.setActiveIndex(0);
           state.setScrollOffset(0);
-          return true;
         } else if (
           key.sequence &&
           key.sequence.length === 1 &&
@@ -791,41 +790,34 @@ export const useSessionBrowserInput = (
           state.setSearchQuery((prev) => prev + key.sequence);
           state.setActiveIndex(0);
           state.setScrollOffset(0);
-          return true;
         }
       } else {
         // Navigation mode input handling.  We're keeping the letter-based controls for non-search
         // mode only, because the letters need to act as input for the search.
         if (key.sequence === 'g') {
           state.setActiveIndex(0);
           state.setScrollOffset(0);
-          return true;
         } else if (key.sequence === 'G') {
           state.setActiveIndex(state.totalSessions - 1);
           state.setScrollOffset(
             Math.max(0, state.totalSessions - SESSIONS_PER_PAGE),
           );
-          return true;
         }
         // Sorting controls.
         else if (key.sequence === 's') {
           cycleSortOrder();
-          return true;
         } else if (key.sequence === 'r') {
           state.setSortReverse(!state.sortReverse);
-          return true;
         }
         // Searching and exit controls.
         else if (key.sequence === '/') {
           state.setIsSearchMode(true);
-          return true;
         } else if (
           key.sequence === 'q' ||
           key.sequence === 'Q' ||
           key.name === 'escape'
         ) {
           onExit();
-          return true;
         }
         // Delete session control.
         else if (key.sequence === 'x' || key.sequence === 'X') {
@@ -855,15 +847,12 @@ export const useSessionBrowserInput = (
                 );
               });
           }
-          return true;
         }
         // less-like u/d controls.
         else if (key.sequence === 'u') {
           moveSelection(-Math.round(SESSIONS_PER_PAGE / 2));
-          return true;
         } else if (key.sequence === 'd') {
           moveSelection(Math.round(SESSIONS_PER_PAGE / 2));
-          return true;
         }
       }
 
@@ -878,21 +867,15 @@ export const useSessionBrowserInput = (
         if (!selectedSession.isCurrentSession) {
           onResumeSession(selectedSession);
         }
-        return true;
       } else if (key.name === 'up') {
         moveSelection(-1);
-        return true;
       } else if (key.name === 'down') {
         moveSelection(1);
-        return true;
       } else if (key.name === 'pageup') {
         moveSelection(-SESSIONS_PER_PAGE);
-        return true;
       } else if (key.name === 'pagedown') {
         moveSelection(SESSIONS_PER_PAGE);
-        return true;
       }
-      return false;
     },
     { isActive: true },
   );