fix: don't set max pods above kubernetes recommended limit (#342)

* fix: don't set max pods above kubernetes recommended limit

Signed-off-by: Jonah Back <[email protected]>

* move min to common

Signed-off-by: Jonah Back <[email protected]>

* remove whitespace

Signed-off-by: Jonah Back <[email protected]>

Author: backjo

controllers/common/utils.go

@@ -256,6 +256,13 @@ func StringSliceContains(x, y []string) bool {
 	return true
 }
 
+func Min(a, b int64) int64 {
+	if a < b {
+		return a
+	}
+	return b
+}
+
 func GetLastElementBy(s, sep string) string {
 	sp := strings.Split(s, sep)
 	return sp[len(sp)-1]

controllers/provisioners/eks/helpers.go

@@ -511,7 +511,8 @@ func (ctx *EksInstanceGroupContext) GetComputedBootstrapOptions() *v1alpha1.Boot
 			ipsPerInterface = 16 //Number of ips in a /28 block
 		}
 
-		maxPods = enis*((aws.Int64Value(instanceTypeNetworkInfo.Ipv4AddressesPerInterface)-1)*ipsPerInterface) + hostNetworkPods
+		// Don't set maxPods above Kubernetes-recommended 110 per node for large clusters.
+		maxPods = common.Min(enis*((aws.Int64Value(instanceTypeNetworkInfo.Ipv4AddressesPerInterface)-1)*ipsPerInterface) + hostNetworkPods, 110)
 
 		if configuration.BootstrapOptions == nil {
 			return &v1alpha1.BootstrapOptions{

controllers/provisioners/eks/helpers_test.go

@@ -403,7 +403,7 @@ func TestCustomNetworkingMaxPods(t *testing.T) {
 				CustomNetworkingEnabledAnnotation:                 "true",
 			},
 			bootstrapOptions: nil,
-			expectedMaxPods:  "--max-pods=290",
+			expectedMaxPods:  "--max-pods=110",
 		},
 		{
 			annotations: map[string]string{