fix: add addl tags for scale to 0 support for windows nodes (#315)

* fix: add addl tags for scale to 0 support for windows nodes

Signed-off-by: Jonah Back <[email protected]>

* move state lookup to initial var statement

Signed-off-by: Jonah Back <[email protected]>

* move instancetype lookup to initial var statement

Signed-off-by: Jonah Back <[email protected]>

* guard numberOfIp tag with nil check for networkInfo

Signed-off-by: Jonah Back <[email protected]>

Co-authored-by: Eytan Avisror <[email protected]>

Author: backjo

controllers/provisioners/eks/helpers.go

@@ -287,6 +287,8 @@ func (ctx *EksInstanceGroupContext) GetAddedTags(asgName string) []*autoscaling.
 		labels        = ctx.GetComputedLabels()
 		taints        = configuration.GetTaints()
 		osFamily      = ctx.GetOsFamily()
+		state         = ctx.GetDiscoveredState()
+		instanceTypeInfo = state.GetInstanceTypeInfo()
 	)
 
 	tags = append(tags, ctx.AwsWorker.NewTag("Name", asgName, asgName))
@@ -302,6 +304,13 @@ func (ctx *EksInstanceGroupContext) GetAddedTags(asgName string) []*autoscaling.
 		switch strings.ToLower(osFamily) {
 		case OsFamilyWindows:
 			tags = append(tags, ctx.AwsWorker.NewTag("k8s.io/cluster-autoscaler/node-template/label/kubernetes.io/os", "windows", asgName))
+			tags = append(tags, ctx.AwsWorker.NewTag("k8s.io/cluster-autoscaler/node-template/label/kubernetes.io/arch", "amd64", asgName))
+
+			instanceTypeNetworkInfo := awsprovider.GetInstanceTypeNetworkInfo(instanceTypeInfo, configuration.InstanceType)
+			if instanceTypeNetworkInfo != nil {
+				numberOfIps := aws.Int64Value(instanceTypeNetworkInfo.Ipv4AddressesPerInterface) - 1
+				tags = append(tags, ctx.AwsWorker.NewTag("k8s.io/cluster-autoscaler/node-template/resources/vpc.amazonaws.com/PrivateIPv4Address", strconv.FormatInt(numberOfIps, 10), asgName))
+			}
 		default:
 			tags = append(tags, ctx.AwsWorker.NewTag("k8s.io/cluster-autoscaler/node-template/label/kubernetes.io/os", "linux", asgName))
 		}