fix: resolve race condition in NSQ scaler test #6843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickbrouwer
changed the title
rickbrouwer
changed the title
rickbrouwer
force-pushed
the
fix-race-nsq
branch
3 times, most recently
from
0715e74 to
2c7dd9c
Compare
|
Semgrep found 7
Detected 'io.WriteString()' writing directly to 'http.ResponseWriter'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package to render data to users. |
rickbrouwer
force-pushed
the
fix-race-nsq
branch
from
2c7dd9c to
141a445
Compare
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
rickbrouwer
force-pushed
the
fix-race-nsq
branch
2 times, most recently
from
95be662 to
b6b5dcf
Compare
…ter usage Signed-off-by: Rick Brouwer <[email protected]>
rickbrouwer
force-pushed
the
fix-race-nsq
branch
from
b6b5dcf to
d97ae73
Compare
Member
Author
|
/skip-e2e |
wozniakjan
approved these changes
Jul 7, 2025
kmoonwright
pushed a commit
to kmoonwright/keda
that referenced
this pull request
Jul 9, 2025
…ter usage (kedacore#6843) Signed-off-by: Rick Brouwer <[email protected]> Signed-off-by: kmoonwright <[email protected]>
kmoonwright
pushed a commit
to kmoonwright/keda
that referenced
this pull request
Jul 9, 2025
…ter usage (kedacore#6843) Signed-off-by: Rick Brouwer <[email protected]> Signed-off-by: kmoonwright <[email protected]>
dpochopsky
pushed a commit
to dpochopsky/keda
that referenced
this pull request
Sep 12, 2025
…ter usage (kedacore#6843) Signed-off-by: Rick Brouwer <[email protected]> Signed-off-by: David Pochopsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TestNSQAggregateDepthandTestNSQGetTopicProducerstests were failing intermittently due to a race condition in the mock HTTP server setup. The tests were usingatomic.NewInt32(-1)followed bycallCount.Inc()and multiplecallCount.Load()calls, which could result in inconsistent values when accessed concurrently.This happens in de amd64 test in PR #6834 and #6546
Checklist