-
Notifications
You must be signed in to change notification settings - Fork 1k
flake: Multi-Components: FederatedResourceQuota enforcement testing #6941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: zhzhuang-zju <[email protected]>
Summary of ChangesHello @zhzhuang-zju, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a recurring test flake by modifying an end-to-end test suite to run serially. The flake was caused by parallel test execution leading to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a flaky test issue by serializing a test suite that was conflicting with another due to concurrent creation and deletion of a FlinkDeployment CRD. The change correctly replaces ginkgo.Describe with framework.SerialDescribe to ensure the test runs serially, which is an effective way to resolve this kind of resource contention in parallel tests. A clear comment has been added to explain the necessity of this change. The fix is appropriate and well-implemented.
XiShanYongYe-Chang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we plan to develop more test cases for FlinkDeployment in subsequent iterations, we could consider using ginkgo.Ordered to organize these test cases related to FlinkDeployment; or we could consider installing the FlinkDeployment CRD in BeforeSuite so that these test cases can run in parallel.
/lgtm
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6941 +/- ##
==========================================
+ Coverage 46.45% 46.46% +0.01%
==========================================
Files 698 698
Lines 47808 47809 +1
==========================================
+ Hits 22207 22213 +6
+ Misses 23931 23927 -4
+ Partials 1670 1669 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RainbowMango
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind flake
What this PR does / why we need it:
https://github.com/karmada-io/karmada/actions/runs/19536609426/job/55932805279
The test suite "[ScheduleMultiTemplate] schedule multi template resource" also creates and deletes the FlinkDeployment CRD, so running two suites in parallel will interfere with each other.
Which issue(s) this PR fixes:
Part of #6814
Special notes for your reviewer:
Does this PR introduce a user-facing change?: