Skip to content

Conversation

@zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind flake

What this PR does / why we need it:
https://github.com/karmada-io/karmada/actions/runs/19536609426/job/55932805279

      customresourcedefinitions.apiextensions.k8s.io "flinkdeployments.flink.apache.org" already exists
      {
          ErrStatus: {
              TypeMeta: {Kind: "Status", APIVersion: "v1"},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "customresourcedefinitions.apiextensions.k8s.io \"flinkdeployments.flink.apache.org\" already exists",
              Reason: "AlreadyExists",
              Details: {
                  Name: "flinkdeployments.flink.apache.org",
                  Group: "apiextensions.k8s.io",
                  Kind: "customresourcedefinitions",
                  UID: "",
                  Causes: nil,
                  RetryAfterSeconds: 0,
              },
              Code: 409,
          },
      }

The test suite "[ScheduleMultiTemplate] schedule multi template resource" also creates and deletes the FlinkDeployment CRD, so running two suites in parallel will interfere with each other.

Which issue(s) this PR fixes:

Part of #6814

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/flake Categorizes issue or PR as related to a flaky test. label Nov 21, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @zhzhuang-zju, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a recurring test flake by modifying an end-to-end test suite to run serially. The flake was caused by parallel test execution leading to AlreadyExists errors when multiple tests attempted to create or delete the same FlinkDeployment Custom Resource Definition. By enforcing serial execution for this specific suite, the change enhances the stability and reliability of the test environment.

Highlights

  • Test Flake Resolution: Addressed a test flake occurring in the 'Multi-Components: FederatedResourceQuota enforcement testing' suite by ensuring it runs serially. This prevents conflicts with other parallel tests that manage the FlinkDeployment Custom Resource Definition (CRD).
  • Test Execution Strategy: Changed the ginkgo.Describe block to framework.SerialDescribe for the affected test suite, explicitly marking it for serial execution to avoid race conditions related to CRD creation and deletion.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a flaky test issue by serializing a test suite that was conflicting with another due to concurrent creation and deletion of a FlinkDeployment CRD. The change correctly replaces ginkgo.Describe with framework.SerialDescribe to ensure the test runs serially, which is an effective way to resolve this kind of resource contention in parallel tests. A clear comment has been added to explain the necessity of this change. The fix is appropriate and well-implemented.

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we plan to develop more test cases for FlinkDeployment in subsequent iterations, we could consider using ginkgo.Ordered to organize these test cases related to FlinkDeployment; or we could consider installing the FlinkDeployment CRD in BeforeSuite so that these test cases can run in parallel.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.46%. Comparing base (6a6fb11) to head (db83754).
⚠️ Report is 2 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6941      +/-   ##
==========================================
+ Coverage   46.45%   46.46%   +0.01%     
==========================================
  Files         698      698              
  Lines       47808    47809       +1     
==========================================
+ Hits        22207    22213       +6     
+ Misses      23931    23927       -4     
+ Partials     1670     1669       -1     
Flag Coverage Δ
unittests 46.46% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2025
@karmada-bot karmada-bot merged commit d6f4db6 into karmada-io:master Nov 21, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants