flaky test: deploy workloads should be rejected in case of no enough quota left

[zhzhuang-zju]

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
refer to #6876 (comment)

Which issue(s) this PR fixes:

Part of #6841

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[gemini-code-assist]

Summary of Changes

Hello @zhzhuang-zju, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a flaky end-to-end test within the FederatedResourceQuota enforcement suite. The flakiness stemmed from a race condition where test assertions or subsequent actions were performed before the FederatedResourceQuota's OverallUsed status was reliably populated. By introducing a specific wait condition that ensures the quota's status is properly initialized, the test is stabilized, accurately reflecting quota enforcement behavior and improving test reliability.

Highlights

• New E2E Test Helper: Introduced a new helper function, WaitFederatedResourceQuotaFitWith, in the E2E test framework to allow waiting for a FederatedResourceQuota to meet specific conditions.
• Flaky Test Fix: Addressed a flaky E2E test in the FederatedResourceQuota enforcement suite by utilizing the new helper function to ensure the OverallUsed status of the quota is initialized before proceeding with test logic, preventing race conditions.
• Status Initialization Check: The WaitFederatedResourceQuotaFitWith function is specifically used to wait until frq.Status.OverallUsed is not nil, ensuring the quota's state is ready for subsequent operations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a flaky test by introducing a wait after creating a FederatedResourceQuota to ensure its status is initialized before proceeding. This is achieved by adding a new helper function, WaitFederatedResourceQuotaFitWith. The approach is sound and should resolve the race condition causing the test flakiness. I have one suggestion to enhance the new helper function for improved logging and code clarity.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.40%. Comparing base (d8473e1) to head (178d828).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #6907   +/-   ##
=======================================
  Coverage   46.39%   46.40%           
=======================================
  Files         697      697           
  Lines       47764    47764           
=======================================
+ Hits        22162    22163    +1     
  Misses      23932    23932           
+ Partials     1670     1669    -1     

Flag	Coverage Δ
unittests	46.40% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[XiShanYongYe-Chang]

/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [XiShanYongYe-Chang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment