add test case

Signed-off-by: zhzhuang-zju <[email protected]>

Author: zhzhuang-zju

pkg/scheduler/core/spreadconstraint/group_clusters_test.go

@@ -68,7 +68,9 @@ func Test_GroupClustersWithScore(t *testing.T) {
 			args: args{
 				clustersScore: generateClusterScore(),
 				placement:     &policyv1alpha1.Placement{},
-				spec:          &workv1alpha2.ResourceBindingSpec{},
+				spec: &workv1alpha2.ResourceBindingSpec{
+					Placement: &policyv1alpha1.Placement{},
+				},
 			},
 			want: want{
 				clusters: []string{"member4", "member2", "member3", "member1"},
@@ -87,7 +89,9 @@ func Test_GroupClustersWithScore(t *testing.T) {
 						},
 					},
 				},
-				spec: &workv1alpha2.ResourceBindingSpec{},
+				spec: &workv1alpha2.ResourceBindingSpec{
+					Placement: &policyv1alpha1.Placement{},
+				},
 			},
 			want: want{
 				clusters: []string{"member4", "member2", "member3", "member1"},
@@ -106,7 +110,9 @@ func Test_GroupClustersWithScore(t *testing.T) {
 						},
 					},
 				},
-				spec: &workv1alpha2.ResourceBindingSpec{},
+				spec: &workv1alpha2.ResourceBindingSpec{
+					Placement: &policyv1alpha1.Placement{},
+				},
 			},
 			want: want{
 				clusters: []string{"member4", "member2", "member3", "member1"},
@@ -126,7 +132,9 @@ func Test_GroupClustersWithScore(t *testing.T) {
 						},
 					},
 				},
-				spec: &workv1alpha2.ResourceBindingSpec{},
+				spec: &workv1alpha2.ResourceBindingSpec{
+					Placement: &policyv1alpha1.Placement{},
+				},
 			},
 			want: want{
 				clusters:  []string{"member4", "member2", "member3", "member1"},
@@ -146,7 +154,9 @@ func Test_GroupClustersWithScore(t *testing.T) {
 						},
 					},
 				},
-				spec: &workv1alpha2.ResourceBindingSpec{},
+				spec: &workv1alpha2.ResourceBindingSpec{
+					Placement: &policyv1alpha1.Placement{},
+				},
 			},
 			want: want{
 				clusters:    []string{"member4", "member2", "member3", "member1"},
@@ -176,7 +186,9 @@ func Test_GroupClustersWithScore(t *testing.T) {
 						},
 					},
 				},
-				spec: &workv1alpha2.ResourceBindingSpec{},
+				spec: &workv1alpha2.ResourceBindingSpec{
+					Placement: &policyv1alpha1.Placement{},
+				},
 			},
 			want: want{
 				clusters:    []string{"member4", "member2", "member3", "member1"},

pkg/scheduler/core/spreadconstraint/select_clusters_test.go

@@ -249,3 +249,75 @@ func TestSelectBestClusters(t *testing.T) {
 		})
 	}
 }
+
+func TestIgnoreCalculateAvailableResource(t *testing.T) {
+	tests := []struct {
+		name      string
+		placement *policyv1alpha1.Placement
+		ignore    bool
+	}{
+		{
+			name:      "when ReplicaScheduling is nil",
+			placement: &policyv1alpha1.Placement{ReplicaScheduling: nil},
+			ignore:    true,
+		},
+		{
+			name: "when strategy is duplicated",
+			placement: &policyv1alpha1.Placement{
+				ReplicaScheduling: &policyv1alpha1.ReplicaSchedulingStrategy{ReplicaSchedulingType: policyv1alpha1.ReplicaSchedulingTypeDuplicated},
+			},
+			ignore: true,
+		},
+		{
+			name: "when strategy is divided, and ReplicaDivisionPreference is Aggregated",
+			placement: &policyv1alpha1.Placement{
+				ReplicaScheduling: &policyv1alpha1.ReplicaSchedulingStrategy{
+					ReplicaSchedulingType:     policyv1alpha1.ReplicaSchedulingTypeDivided,
+					ReplicaDivisionPreference: policyv1alpha1.ReplicaDivisionPreferenceAggregated,
+				},
+			},
+			ignore: false,
+		},
+		{
+			name: "when strategy is divided, and ReplicaDivisionPreference is Weighted, and WeightPreference is nil",
+			placement: &policyv1alpha1.Placement{
+				ReplicaScheduling: &policyv1alpha1.ReplicaSchedulingStrategy{
+					ReplicaSchedulingType:     policyv1alpha1.ReplicaSchedulingTypeDivided,
+					ReplicaDivisionPreference: policyv1alpha1.ReplicaDivisionPreferenceWeighted,
+					WeightPreference:          nil,
+				},
+			},
+			ignore: true,
+		},
+		{
+			name: "when strategy is divided, and ReplicaDivisionPreference is Weighted, and WeightPreference is DynamicWeight",
+			placement: &policyv1alpha1.Placement{
+				ReplicaScheduling: &policyv1alpha1.ReplicaSchedulingStrategy{
+					ReplicaSchedulingType:     policyv1alpha1.ReplicaSchedulingTypeDivided,
+					ReplicaDivisionPreference: policyv1alpha1.ReplicaDivisionPreferenceAggregated,
+					WeightPreference:          &policyv1alpha1.ClusterPreferences{DynamicWeight: policyv1alpha1.DynamicWeightByAvailableReplicas},
+				},
+			},
+			ignore: false,
+		},
+		{
+			name: "when strategy is divided, and ReplicaDivisionPreference is Weighted, and WeightPreference is StaticWeightList",
+			placement: &policyv1alpha1.Placement{
+				ReplicaScheduling: &policyv1alpha1.ReplicaSchedulingStrategy{
+					ReplicaSchedulingType:     policyv1alpha1.ReplicaSchedulingTypeDivided,
+					ReplicaDivisionPreference: policyv1alpha1.ReplicaDivisionPreferenceWeighted,
+					WeightPreference:          &policyv1alpha1.ClusterPreferences{StaticWeightList: make([]policyv1alpha1.StaticClusterWeight, 0)},
+				},
+			},
+			ignore: true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			got := ignoreCalculateAvailableResource(tt.placement)
+			if !reflect.DeepEqual(got, tt.ignore) {
+				t.Errorf("ignoreCalculateAvailableResource() = %v, want %v", got, tt.ignore)
+			}
+		})
+	}
+}