From ff34ea1c9d6ebfdf146dc7d89f8b0b5af04734be Mon Sep 17 00:00:00 2001 From: Tim Kreuzer Date: Tue, 13 May 2025 13:48:03 +0200 Subject: [PATCH 1/2] add mount type for volume_binds generated mounts --- dockerspawner/swarmspawner.py | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/dockerspawner/swarmspawner.py b/dockerspawner/swarmspawner.py index 4c84b6e6..bdaf536a 100644 --- a/dockerspawner/swarmspawner.py +++ b/dockerspawner/swarmspawner.py @@ -116,6 +116,16 @@ def mount_driver_config(self): ) return None + volume_binds_mount_type = Unicode( + default_value="bind", + allow_None=False, + config=True, + help=""" + Use this mount type for creating mounts of volume_binds. + Check https://docs.docker.com/engine/storage/volumes/ for allowed mount types. + """ + ) + @property def mounts(self): if len(self.volume_binds): @@ -124,7 +134,7 @@ def mounts(self): Mount( target=vol["bind"], source=host_loc, - type="bind", + type=self.volume_binds_mount_type, read_only=vol["mode"] == "ro", driver_config=driver, ) From 6bd1b8d953618d0cd442be27b73ccc976a6a05dc Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Tue, 13 May 2025 11:50:12 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- dockerspawner/swarmspawner.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dockerspawner/swarmspawner.py b/dockerspawner/swarmspawner.py index bdaf536a..a5d45a6f 100644 --- a/dockerspawner/swarmspawner.py +++ b/dockerspawner/swarmspawner.py @@ -123,7 +123,7 @@ def mount_driver_config(self): help=""" Use this mount type for creating mounts of volume_binds. Check https://docs.docker.com/engine/storage/volumes/ for allowed mount types. - """ + """, ) @property