add warning if requesting x64 on apple silicon runners #300
Conversation
IanButterworth
force-pushed
the
ib/warn_x64_macos
branch
from
582765a to
138418b
Compare
IanButterworth
force-pushed
the
ib/warn_x64_macos
branch
from
138418b to
59f78c1
Compare
|
I say in the wild... but it's the case on this CI... 😂
|
IanButterworth
force-pushed
the
ib/warn_x64_macos
branch
from
e212682 to
ee74250
Compare
| throw new Error(`Arch input must not be null`); | ||
| } | ||
| if (originalArchInput == 'x64' && os.platform() == 'darwin' && os.arch() == 'arm64') { | ||
| core.warning('[setup-julia] x64 arch has been requested on a macOS runner that has an arm64 (Apple Silicon) architecture. You may have meant to use the "aarch64" arch instead (or left it unspecified for the correct default).'); |
There was a problem hiding this comment.
This seems misleading, since leaving it unspecified causes it to throw an exception and fail:
setup-julia/src/setup-julia.ts
Lines 61 to 63 in 5c9647d
https://github.com/vtjnash/Glob.jl/actions/runs/11898442357/job/33154951261?pr=44
There was a problem hiding this comment.
Unspecified as in not an empty string, just not set at all.
There was a problem hiding this comment.
If you do this:
- uses: julia-actions/setup-julia@desiredtag
with:
version: '1.10'Then setup-julia will default to the architecture of the runner.
In contrast, if you do this:
- uses: julia-actions/setup-julia@desiredtag
with:
version: '1.10'
arch: ''Then setup-julia will (correctly) throw an error.
There was a problem hiding this comment.
If you use a matrix and don't specify arch, then it will get an empty string here
There was a problem hiding this comment.
The following two are equivalent:
- uses: julia-actions/setup-julia@desiredtag
with:
version: '1.10'- uses: julia-actions/setup-julia@desiredtag
with:
version: '1.10'
arch: 'default'There was a problem hiding this comment.
The documentation says it defaults to '', though I agree that using "default" instead works
Lines 56 to 57 in 5c9647d
There was a problem hiding this comment.
If you use a matrix, you shouldn't be passing an empty string ''. You should pass 'default' instead.
There was a problem hiding this comment.
Yeah, the readme is misleading. They're all like that, note the default behaviors are written above the empty string examples. Not sure what the clearest way to write them all is.
There was a problem hiding this comment.
We should fix up the README. For inputs that are optional (like arch), we should put a reasonable default in there.
Tries to safeguard julia-actions/setup-julia#300 JuliaLang/julia#55878 where the user has requested an incorrect architecture and thus we may believe we can load MKL until we check `MKL_jll.is_available() == false`. The reason is because we're being lied to about `@static if Sys.ARCH === :x86_64 || Sys.ARCH === :i686` which then makes it take this branch and then MKL does not exist. We could instead check `isapple` another type of workaround here and 99% of users would be perfectly fine, but if this is safe this is slightly better for the 1 remaining Intel Apple user that exists in the wild somewhere.
MacOS ARM does not have x86 so you're doing bad things here JuliaLang/julia#55878 and julia-actions/setup-julia#300
MacOS ARM does not have x86 so you're doing bad things here JuliaLang/julia#55878 and julia-actions/setup-julia#300
* Better safeguard on unloadable MKL Tries to safeguard julia-actions/setup-julia#300 JuliaLang/julia#55878 where the user has requested an incorrect architecture and thus we may believe we can load MKL until we check `MKL_jll.is_available() == false`. The reason is because we're being lied to about `@static if Sys.ARCH === :x86_64 || Sys.ARCH === :i686` which then makes it take this branch and then MKL does not exist. We could instead check `isapple` another type of workaround here and 99% of users would be perfectly fine, but if this is safe this is slightly better for the 1 remaining Intel Apple user that exists in the wild somewhere. * Update LinearSolve.jl
I think this might be happening quite a bit in the wild.
i.e. JuliaLang/julia#55878