Create dynamic var for data readers #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports the use case of users who have values with tagged literals stored in their databases. Just as with clojure.core/*data-readers* and clojure.core/default-data-readers, there is also a static var containing the default readers to fall back to in contexts where the dynamic value has been rebound, which is used to initialize the dynamic var.
Contributor
Author
|
I didn't add tests for the custom reader capabilities. I can if you would like me to. |
Contributor
|
It would be great if you could add a test for this! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This supports the use case of users who have values with tagged literals stored in their databases. Just as with
clojure.core/*data-readers*andclojure.core/default-data-readers, there is also a static var containing the default readers to fall back to in contexts where the dynamic value has been rebound, which is used to initialize the dynamic var.Testing
Tested locally with
lein test- no issues.Questions
I am not sure if the naming of
datalevin-data-readersis unwieldy, but I named those vars like that to avoid potentially shadowing the equivalent vars fromclojure.core. They can be renamed to something different if it would be better.