Fix list-objects returning nothing after restarting #220
Conversation
jubos
left a comment
jubos
left a comment
There was a problem hiding this comment.
Thanks for the PR. Mainly some style nits before it can be merged. Can you also squash your diff into one logical change instead of 2 diffs?
lib/fakes3/file_store.rb
Outdated
| end | ||
| return metadata | ||
| end | ||
| private |
There was a problem hiding this comment.
Style nit: Indentation looks off here.
| Dir[File.join(root,"*")].each do |bucket| | ||
| bucket_name = File.basename(bucket) | ||
| bucket_obj = Bucket.new(bucket_name,Time.now,get_objects(bucket_name, bucket)) | ||
| puts "root bucket: #{bucket_name}" |
There was a problem hiding this comment.
Leave the puts out to avoid console spew.
| get_object(bucket_name, File.basename(filepath), nil) | ||
| end | ||
| end | ||
| private |
| end | ||
| end | ||
| private | ||
| def get_objects bucket_name, path, root_path=nil |
There was a problem hiding this comment.
Use 2 spaces for indentation and () in the method declaration like the other methods in the class.
|
Thanks for your feedback @jubos! I actually made this PR from @saltzmanjoelh's fork (I didn't even know you could do a PR from a repo you don't own), which means I'm not able to push more code in order to amend this commit. Instead I've opened a new PR, #221, which hopefully addresses your comments, and I'll close this one. |
2 participants
Currently if fake-s3 is restarted, it always returns an empty response for the
list-objectsaction. However, the objects are still there and can be fetched withget-objectif you already know the key.This PR is similar to this one, but including the extra fixes in comments from @Allactaga and @mark2997.