-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add showAllEvents Calendar Prop
#1808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,6 +102,7 @@ class MonthView extends React.Component { | |
| longPressThreshold, | ||
| accessors, | ||
| getters, | ||
| showAllEvents, | ||
| } = this.props | ||
|
|
||
| const { needLimitMeasure, rowLimit } = this.state | ||
|
|
@@ -120,7 +121,7 @@ class MonthView extends React.Component { | |
| date={date} | ||
| range={week} | ||
| events={events} | ||
| maxRows={rowLimit} | ||
| maxRows={showAllEvents ? Infinity : rowLimit} | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you double check that no code assumes this number is bounded? e.g. uses it as the upper bound in a loop
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just confirmed that no code assumes this number is bound. It is only used when determining "extra" segments here |
||
| selected={selected} | ||
| selectable={selectable} | ||
| components={components} | ||
|
|
@@ -137,6 +138,7 @@ class MonthView extends React.Component { | |
| longPressThreshold={longPressThreshold} | ||
| rtl={this.props.rtl} | ||
| resizable={this.props.resizable} | ||
| showAllEvents={showAllEvents} | ||
| /> | ||
| ) | ||
| } | ||
|
|
@@ -342,6 +344,7 @@ MonthView.propTypes = { | |
| onDoubleClickEvent: PropTypes.func, | ||
| onKeyPressEvent: PropTypes.func, | ||
| onShowMore: PropTypes.func, | ||
| showAllEvents: PropTypes.bool, | ||
| onDrillDown: PropTypes.func, | ||
| getDrilldownView: PropTypes.func.isRequired, | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we only add this wrapper if needed? I don't want to have to deal with potential flex box issues in other browsers due to a new div here