Skip to content

Make scrollToTime=00:00 working #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Make scrollToTime=00:00 working #1501

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1024f4b
make scrollToTime=00:00 working
amok Oct 18, 2019
fa3e0fc
check _scrollRatio is not null
amok Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/TimeGrid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ export default class TimeGrid extends Component {

this.scrollRef = React.createRef()
this.contentRef = React.createRef()
this._scrollRatio = null
}

componentWillMount() {
Expand Down Expand Up @@ -267,7 +268,7 @@ export default class TimeGrid extends Component {
}

applyScroll() {
if (this._scrollRatio) {
if (typeof this._scrollRatio === 'number') {
Copy link
Owner

@jquense jquense Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this._scrollRatio != null

Copy link
Contributor Author

@amok amok Oct 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jquense done

const content = this.contentRef.current
content.scrollTop = content.scrollHeight * this._scrollRatio
// Only do this once
Expand Down