-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Provide SASS implementation of styles #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
merge of latest head changes
merging latest from base project
chore: upgrade storybook (jquense#1308)
…calendar into feature/sass * 'feature/sass' of https://github.com/cutterbl/react-big-calendar: Remove duplicate style for parity with the LESS implementation from jquense#1283 Provide SASS implementation of styles
|
hey this is awesome thanks! I think at this point we should just switch to sass entirely, it's basically the preprocessor winner at this point, and use with node via npm is fine nowadays. in any case this is great, would you want to do the additional work to make this the primary styling means (doc changes, remove old files, etc)? |
|
@jquense I can handle the doc changes, and updates to the build steps (plus storybook). That said, don't you think there's value in giving the developer the option? I support multiple applications, personally, some using SASS and some using LESS. If you want to drop LESS all together, that's cool, just throwing it out there... |
|
I do like providing both, but it's too much work to maintain, and to much to ask contributors to provide styles twice, I think it's generally better to do one, and convert between them automatically or just provide one |
|
@jquense OK, I get it. I'll update the markdown, Storybook webpack, examples webpack, and the build steps. I'll also look through the Examples site to see if there are any ref's there to consider. |
I created SASS versions of the styles. I was going to clean it up and make it more "SASS"y, but decided to keep exact same structure for parity with the LESS, making it easier to find and make changes to both when necessary.
I provided npm scripts for running a SASS builds (for testing), as well as copying the SASS files into the
libdirectory as part of thebuildprocess. I also figured out how to change the implementation in Storybook, for testing. I left those bits commented out after running my testing, so they can be easily interchanged when necessary.I also provided a Custom Styling section to the README file, giving a rough outline on how a developer can include either the LESS or the SASS in their own application for overriding styles to match their own application styling, as well as a caveat warning about how their changes could adversely affect Big Calendar if not tested.