Skip to content

Remove global window from code called during server-side rendering #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Remove global window from code called during server-side rendering #1195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ parser: babel-eslint
extends:
- jason/react
- prettier

env:
es6: true
rules:
global-require: off
no-unused-vars: [2, {
Expand Down
2 changes: 1 addition & 1 deletion src/utils/Resources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export default function Resources(resources, accessors) {
},

groupEvents(events) {
const eventsByResource = new window.Map()
const eventsByResource = new Map()

if (!resources) {
// Return all events if resources are not provided
Expand Down