Skip to content

Fixed calculation of slots number for date when DST ends. #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Fixed calculation of slots number for date when DST ends. #1046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/utils/TimeSlots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import dates from './dates'

const getDstOffset = (start, end) =>
Math.abs(start.getTimezoneOffset() - end.getTimezoneOffset())
start.getTimezoneOffset() - end.getTimezoneOffset()

const getKey = (min, max, step, slots) =>
`${+dates.startOf(min, 'minutes')}` +
Expand Down Expand Up @@ -105,7 +105,7 @@ export function getSlotMetrics({ min: start, max: end, step, timeslots }) {
if (dates.lt(date, start, 'minutes')) return slots[0]

const diffMins = dates.diff(start, date, 'minutes')
return slots[(diffMins - diffMins % step) / step + offset]
return slots[(diffMins - (diffMins % step)) / step + offset]
},

startsBeforeDay(date) {
Expand All @@ -130,11 +130,11 @@ export function getSlotMetrics({ min: start, max: end, step, timeslots }) {

const rangeStartMin = positionFromDate(rangeStart)
const rangeEndMin = positionFromDate(rangeEnd)
const top = rangeStartMin / totalMin * 100
const top = (rangeStartMin / totalMin) * 100

return {
top,
height: rangeEndMin / totalMin * 100 - top,
height: (rangeEndMin / totalMin) * 100 - top,
start: positionFromDate(rangeStart),
startDate: rangeStart,
end: positionFromDate(rangeEnd),
Expand Down