fix: fix dayjs localizer merge function to not change min and max#2712
Merged
Conversation
Contributor
|
@cutterbl this would be a big help in our production app, if you're able to take a peek! |
Contributor
|
Any chance we can get this merged @cutterbl ? :) |
|
Would appreciate a merge! Thanks @cutterbl Hope this will fix issue shown in image... |
github-actions Bot
pushed a commit
that referenced
this pull request
May 28, 2025
## [1.19.2](v1.19.1...v1.19.2) (2025-05-28) ### Bug Fixes * fix dayjs localizer merge function to not change min and max upon tz change ([#2712](#2712)) ([7d2aa77](7d2aa77))
Contributor
|
🎉 This PR is included in version 1.19.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hello guys, I guess this PR causes this problem: On localhost, the time slots match min/max I pass to component's prop But it displays wrong when I build it on to production I think this is because production uses version 1.19.2, while on localhost I use 1.15.0 (I don't install with lockfile immutable) If I inspect the outer component, I see localhost props and production props are the same, which means there's some internal conversion that makes the time display wrong I can confirm version 1.15.0 don't have this, I've revert the code and it works well |
Closed
5 tasks
leonpro00
added a commit
to leonpro00/react-calendar
that referenced
this pull request
Sep 17, 2025
## [1.19.2](jquense/react-big-calendar@v1.19.1...v1.19.2) (2025-05-28) ### Bug Fixes * fix dayjs localizer merge function to not change min and max upon tz change ([#2712](jquense/react-big-calendar#2712)) ([7d2aa77](jquense/react-big-calendar@7d2aa77))
github-actions Bot
pushed a commit
to additio/react-big-calendar
that referenced
this pull request
Oct 15, 2025
# [1.3.0](v1.2.0...v1.3.0) (2025-10-15) ### Bug Fixes * add appearance: button for better cross-browser button styling c… ([jquense#2677](https://github.com/additio/react-big-calendar/issues/2677)) ([85be249](85be249)), closes [jquense#2676](https://github.com/additio/react-big-calendar/issues/2676) * Clean up preview elements after dropping from outside ([jquense#2746](https://github.com/additio/react-big-calendar/issues/2746)) ([652502f](652502f)) * correctly show +more buttons on slots with hidden spanning events ([jquense#2744](https://github.com/additio/react-big-calendar/issues/2744)) ([dbd0b0a](dbd0b0a)) * Customize drag from outside event's length ([jquense#2681](https://github.com/additio/react-big-calendar/issues/2681)) ([2ed9465](2ed9465)), closes [jquense#2680](https://github.com/additio/react-big-calendar/issues/2680) * **dayjs localizer:** reverts previous changs, as it was casting a date as UTC instead of local time ([jquense#2759](https://github.com/additio/react-big-calendar/issues/2759)) ([7ba9e24](7ba9e24)), closes [jquense#2758](https://github.com/additio/react-big-calendar/issues/2758) * **dnd:** added check for null dragFromOutsideItem, updated example ([jquense#2651](https://github.com/additio/react-big-calendar/issues/2651)) ([17e62a3](17e62a3)), closes [jquense#2616](https://github.com/additio/react-big-calendar/issues/2616) [jquense#2383](https://github.com/additio/react-big-calendar/issues/2383) * fix dayjs localizer merge function to not change min and max upon tz change ([jquense#2712](https://github.com/additio/react-big-calendar/issues/2712)) ([7d2aa77](7d2aa77)) * issue [jquense#2534](https://github.com/additio/react-big-calendar/issues/2534) ([jquense#2566](https://github.com/additio/react-big-calendar/issues/2566)) ([10cfe84](10cfe84)) * Replaces createFactory with createElement ([jquense#2754](https://github.com/additio/react-big-calendar/issues/2754)) ([23a0fae](23a0fae)), closes [jquense#2377](https://github.com/additio/react-big-calendar/issues/2377) [jquense#1831](https://github.com/additio/react-big-calendar/issues/1831) [jquense#2740](https://github.com/additio/react-big-calendar/issues/2740) * **Toolbar:** cursor styling on hover ([jquense#2700](https://github.com/additio/react-big-calendar/issues/2700)) ([7029eb3](7029eb3)), closes [jquense#2697](https://github.com/additio/react-big-calendar/issues/2697) * update doc type of onDropFromOutside function signature ([5438fb5](5438fb5)) * Update Slack channel invite in README.md ([47dadc3](47dadc3)) * Update Slack channel invite link in README-ar.md ([de8dd0f](de8dd0f)) ### Features * add support for React 19 ([jquense#2710](https://github.com/additio/react-big-calendar/issues/2710)) ([4d39499](4d39499)) * adds a new event id accessor ([jquense#2693](https://github.com/additio/react-big-calendar/issues/2693)) ([9883ace](9883ace)) * **components:** showMore component customization ([jquense#2537](https://github.com/additio/react-big-calendar/issues/2537)) ([afb3138](afb3138)), closes [jquense#2391](https://github.com/additio/react-big-calendar/issues/2391) * **dayPropGetter:** pass resourceId to method ([jquense#2650](https://github.com/additio/react-big-calendar/issues/2650)) ([272eb88](272eb88)), closes [jquense#2634](https://github.com/additio/react-big-calendar/issues/2634) * implement Conditional Resource Grouping ([jquense#2679](https://github.com/additio/react-big-calendar/issues/2679)) ([d52f836](d52f836)) * **time-indicator-wrapper:** expose time indicator wrapper component ([jquense#2747](https://github.com/additio/react-big-calendar/issues/2747)) ([10b8041](10b8041))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2688
Fixes dayjs localizer merge function so min and max of the day stays always the same.