Skip to content

Commit 94e3679

Browse files
TrySoundjquense
authored andcommitted
Chore: clean up prop-types (#1344)
* Update size snapshot * Clean up prop-types - replaced elementType with builtin one - removed unused custom prop type
1 parent 5d93c9d commit 94e3679

3 files changed

Lines changed: 31 additions & 45 deletions

File tree

.size-snapshot.json

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
11
{
22
"./dist/react-big-calendar.js": {
3-
"bundled": 561778,
4-
"minified": 171458,
5-
"gzipped": 50401
3+
"bundled": 561903,
4+
"minified": 171545,
5+
"gzipped": 50435
66
},
77
"./dist/react-big-calendar.min.js": {
8-
"bundled": 498115,
9-
"minified": 152108,
10-
"gzipped": 45892
8+
"bundled": 498126,
9+
"minified": 152147,
10+
"gzipped": 45902
1111
},
1212
"dist/react-big-calendar.esm.js": {
13-
"bundled": 169709,
14-
"minified": 81572,
15-
"gzipped": 20100,
13+
"bundled": 169800,
14+
"minified": 81627,
15+
"gzipped": 20102,
1616
"treeshaked": {
1717
"rollup": {
18-
"code": 63051,
19-
"import_statements": 1466
18+
"code": 63039,
19+
"import_statements": 1418
2020
},
2121
"webpack": {
22-
"code": 66570
22+
"code": 66506
2323
}
2424
}
2525
}

src/Calendar.js

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import uncontrollable from 'uncontrollable'
44
import cn from 'classnames'
55
import {
66
accessor,
7-
elementType,
87
dateFormat,
98
dateRangeFormat,
109
views as componentViews,
@@ -670,34 +669,34 @@ class Calendar extends React.Component {
670669
* ```
671670
*/
672671
components: PropTypes.shape({
673-
event: elementType,
674-
eventWrapper: elementType,
675-
eventContainerWrapper: elementType,
676-
dateCellWrapper: elementType,
677-
timeSlotWrapper: elementType,
678-
timeGutterHeader: elementType,
679-
resourceHeader: elementType,
672+
event: PropTypes.elementType,
673+
eventWrapper: PropTypes.elementType,
674+
eventContainerWrapper: PropTypes.elementType,
675+
dateCellWrapper: PropTypes.elementType,
676+
timeSlotWrapper: PropTypes.elementType,
677+
timeGutterHeader: PropTypes.elementType,
678+
resourceHeader: PropTypes.elementType,
680679

681-
toolbar: elementType,
680+
toolbar: PropTypes.elementType,
682681

683682
agenda: PropTypes.shape({
684-
date: elementType,
685-
time: elementType,
686-
event: elementType,
683+
date: PropTypes.elementType,
684+
time: PropTypes.elementType,
685+
event: PropTypes.elementType,
687686
}),
688687

689688
day: PropTypes.shape({
690-
header: elementType,
691-
event: elementType,
689+
header: PropTypes.elementType,
690+
event: PropTypes.elementType,
692691
}),
693692
week: PropTypes.shape({
694-
header: elementType,
695-
event: elementType,
693+
header: PropTypes.elementType,
694+
event: PropTypes.elementType,
696695
}),
697696
month: PropTypes.shape({
698-
header: elementType,
699-
dateHeader: elementType,
700-
event: elementType,
697+
header: PropTypes.elementType,
698+
dateHeader: PropTypes.elementType,
699+
event: PropTypes.elementType,
701700
}),
702701
}),
703702

src/utils/propTypes.js

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,7 @@
11
import PropTypes from 'prop-types'
2-
import elementType from 'prop-types-extra/lib/elementType'
32
import all from 'prop-types-extra/lib/all'
43
import { views as Views } from './constants'
54

6-
export { elementType }
7-
8-
export let eventComponent = PropTypes.oneOfType([
9-
elementType,
10-
PropTypes.shape({
11-
month: elementType,
12-
week: elementType,
13-
day: elementType,
14-
agenda: elementType,
15-
}),
16-
])
17-
185
let viewNames = Object.keys(Views).map(k => Views[k])
196

207
export let accessor = PropTypes.oneOfType([PropTypes.string, PropTypes.func])
@@ -50,7 +37,7 @@ export let views = PropTypes.oneOfType([
5037
let isBuiltinView =
5138
viewNames.indexOf(key) !== -1 && typeof prop[key] === 'boolean'
5239

53-
return isBuiltinView || !(err = elementType(prop, key, ...args))
40+
return isBuiltinView || !(err = PropTypes.elementType(prop, key, ...args))
5441
})
5542

5643
return err || null

0 commit comments

Comments
 (0)