Merge pull request onsip#50 from joseph-onsip/rejectReinvite

Session: on re-INVITE, send 488 instead of calling this.receiveReinvite

fixes onsip#19

Author: joseph-onsip

src/Session.js

@@ -622,7 +622,9 @@ Session.prototype = {
       case SIP.C.INVITE:
         if(this.status === C.STATUS_CONFIRMED) {
           this.logger.log('re-INVITE received');
-          this.receiveReinvite(request);
+          // Switch these two lines to try re-INVITEs:
+          //this.receiveReinvite(request);
+          request.reply(488, null, ["Warning: Cannot update media description"]);
         }
         break;
       case SIP.C.INFO:

test/spec/SpecSession.js

@@ -1445,7 +1445,7 @@ describe('InviteServerContext', function() {
     });
 
     describe('method is INVITE', function() {
-      it('calls receiveReinvite', function() {
+      xit('calls receiveReinvite', function() {
         InviteServerContext.status = 12;
         req = SIP.Parser.parseMessage('INVITE sip:[email protected];transport=ws;aor=james%40onsnip.onsip.com SIP/2.0\r\nMax-Forwards: 65\r\nTo: <sip:[email protected]>\r\nFrom: "test1" <sip:[email protected]>;tag=rto5ib4052\r\nCall-ID: grj0liun879lfj35evfq\r\nCSeq: 1798 INVITE\r\nContact: <sip:[email protected];transport=ws;ob>\r\nAllow: ACK,CANCEL,BYE,OPTIONS,INVITE,MESSAGE\r\nContent-Type: application/json\r\nSupported: outbound\r\nUser-Agent: SIP.js 0.5.0-devel\r\nContent-Length: 11\r\n\r\na=sendrecv\r\n', InviteServerContext.ua);
 
@@ -2095,7 +2095,7 @@ describe('InviteClientContext', function() {
       expect(InviteClientContext.terminated).toHaveBeenCalledWith(request, SIP.C.causes.BYE);
     });
 
-    it('logs and calls receiveReinvite if request method is INVITE', function() {
+    xit('logs and calls receiveReinvite if request method is INVITE', function() {
       InviteClientContext.status = 12;
       request.method = SIP.C.INVITE;